output-json: avoid freeing caller-owned JSON builder - #15599
Closed
urvalkheni wants to merge 1 commit into
Closed
Conversation
EveEmailLogJsonData() freed the provided SCJsonBuilder when SMTP state was unavailable, even though ownership remains with the caller. The caller may continue using the builder for cleanup after the function returns failure. Return failure without freeing the builder and add defensive NULL checks in EveSmtpDataLogger(). Signed-off-by: Urval Kheni <urvalkheni777@gmail.com>
victorjulien
approved these changes
Jun 10, 2026
victorjulien
left a comment
victorjulien
left a comment
Member
There was a problem hiding this comment.
Nice find, thanks. Weird that the compiler didn't complain about the NULL as bool return.
Merged
Member
|
Merged in #15601, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #15594.
Link to ticket:
https://redmine.openinfosecfoundation.org/issues/8647
Describe changes:
This is a small correctness/hardening fix to keep ownership handling consistent in the SMTP Eve logging path.