Yaml null 8651 v5 - #15626
Closed
catenacyber wants to merge 2 commits into
Closed
Conversation
Ticket: 8651 Behaves like SCConfGet but returns 0 on null value
Ticke: 8651 Uses it in place when we dereferenced the value straight away after checking SCConfGet result but not its value
catenacyber
requested review from
a team,
jasonish and
victorjulien
as code owners
June 12, 2026 11:41
Closed
|
WARNING:
Pipeline = 32010 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #15626 +/- ##
==========================================
- Coverage 82.87% 82.87% -0.01%
==========================================
Files 1006 1006
Lines 273527 273531 +4
==========================================
- Hits 226698 226682 -16
- Misses 46829 46849 +20
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
jasonish
approved these changes
Jun 12, 2026
victorjulien
approved these changes
Jun 12, 2026
Merged
Member
|
Merged in #15636, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/8651
Describe changes:
SV_BRANCH=OISF/suricata-verify#3162
#15622 with better
SCConfGetNonNull