websocket: accepts config value with units - #15633
Closed
catenacyber wants to merge 1 commit into
Closed
Conversation
Ticket: 8552 As was the commented out example
|
Information: QA ran without warnings. Pipeline = 32018 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #15633 +/- ##
==========================================
- Coverage 82.87% 82.87% -0.01%
==========================================
Files 1006 1006
Lines 273527 273530 +3
==========================================
- Hits 226698 226695 -3
- Misses 46829 46835 +6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
victorjulien
approved these changes
Jun 12, 2026
| if let Ok(vu) = u32::try_from(v) { | ||
| WEBSOCKET_MAX_PAYLOAD_SIZE = vu; | ||
| } else { | ||
| SCLogError!( |
Member
There was a problem hiding this comment.
I wish we would fix this pattern. We issue errors, but they have no effect, so they are effectively warnings. But we really should propagate these errors I think. Anyway, since this is a common pattern I'll not block the PR over it.
Merged
Member
|
Merged in #15636, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/8552
Describe changes:
#15627 with rustfmt fix