Backport8 8464 8624 8662 8663 v1 - #15701
Closed
catenacyber wants to merge 4 commits into
Closed
Conversation
DetectEngineThreadCtxInitKeywords returns TM_ECODE_FAILED when a per-thread keyword init fails (for example DetectFilemagicThreadInit), but ThreadCtxDoInit discarded that result and still returned OK. The detect thread then ran with a partially initialized keyword context array, producing indeterminate results. Propagate the failure so the callers abort thread init and clean up. Add a unit test that registers a keyword whose thread init fails and verifies that DetectEngineThreadCtxInit reports the failure. Ticket: OISF#8237 (cherry picked from commit df35324)
Ticket: 8624 (cherry picked from commit 3ca2ed2)
The ftpdata_command would never match a RETR in the to_server direction, or a STOR in the to_client direction, this effectively makes the ftpdata_command applicable to passive mode only. Instead, remove the directionality on the ftpdata_command. Its "meta" information passed from the control channel and isn't really directional. I think the idea was to abstract away active/passive from the rule writer, but unfortunately doesn't allow the ftpdata_command keyword to work in the more strict firewll mode. Ticket: OISF#8663 (cherry picked from commit 2fe4bb2)
Contributor
Author
|
Replaced by #15702 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main-8.0.x #15701 +/- ##
==============================================
- Coverage 81.65% 81.64% -0.01%
==============================================
Files 1016 1016
Lines 276653 276687 +34
==============================================
+ Hits 225890 225905 +15
- Misses 50763 50782 +19
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/8655
https://redmine.openinfosecfoundation.org/issues/8625
https://redmine.openinfosecfoundation.org/issues/8670
https://redmine.openinfosecfoundation.org/issues/8669
Describe changes:
SV_BRANCH=OISF/suricata-verify#3180