Skip to content

dag: check rlen is a valid length - #16018

Merged
victorjulien merged 1 commit into
OISF:main-8.0.xfrom
sfd:source-erf-dag-rlen-loop-8804-backport-80x
Aug 19, 2026
Merged

dag: check rlen is a valid length#16018
victorjulien merged 1 commit into
OISF:main-8.0.xfrom
sfd:source-erf-dag-rlen-loop-8804-backport-80x

Conversation

@sfd

@sfd sfd commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Ticket: 8804

(cherry picked from commit a37b75a)

Contribution style:

Our Contribution agreements:

Changes (if applicable):

Link to ticket: https://redmine.openinfosecfoundation.org/issues/8804

Describe changes:

  • Backport from Ticket 8797 to main-8.0.x
  • Add check to rlen value read from ERF record to avoid potential infinite loop, must be >= dag_record_length (16).
  • Similar check exists in source_erf_file already.

Provide values to any of the below to override the defaults.

  • To use a Suricata-Verify or Suricata-Update pull request,
    link to the pull request in the respective _BRANCH variable.
  • Leave unused overrides blank or remove.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=

Ticket: 8797

Add check to rlen value read from ERF record to avoid potential infinite loop, must be >= dag_record_length (16).

Similar check exists in source_erf_file already.

(cherry picked from commit a37b75a)
@sfd
sfd requested a review from victorjulien as a code owner August 13, 2026 02:00
@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.65%. Comparing base (27ff8c8) to head (b91ef71).

Additional details and impacted files
@@              Coverage Diff               @@
##           main-8.0.x   #16018      +/-   ##
==============================================
- Coverage       81.68%   81.65%   -0.03%     
==============================================
  Files            1016     1016              
  Lines          276981   276981              
==============================================
- Hits           226245   226181      -64     
- Misses          50736    50800      +64     
Flag Coverage Δ
fuzzcorpus 63.83% <ø> (-0.08%) ⬇️
livemode 18.63% <ø> (-0.05%) ⬇️
netns 20.15% <ø> (-0.01%) ⬇️
pcap 44.45% <ø> (-0.05%) ⬇️
suricata-verify 65.15% <ø> (-0.06%) ⬇️
unittests 58.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@victorjulien victorjulien added this to the 9.0 milestone Aug 13, 2026
@sfd

sfd commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @victorjulien, please merge as appropriate

@victorjulien victorjulien modified the milestones: 9.0, 8.0 Aug 14, 2026
@victorjulien
victorjulien merged commit b91ef71 into OISF:main-8.0.x Aug 19, 2026
60 of 61 checks passed
@victorjulien

Copy link
Copy Markdown
Member

Merged in #16042, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants