Skip to content

http: configures libhtp to allow spaces in uri#6884

Closed
catenacyber wants to merge 1 commit intoOISF:masterfrom
catenacyber:http-uri-spaces-v6
Closed

http: configures libhtp to allow spaces in uri#6884
catenacyber wants to merge 1 commit intoOISF:masterfrom
catenacyber:http-uri-spaces-v6

Conversation

@catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/2881

Describe changes:

  • configures libhtp to allow spaces in URIs

Modifies #6882 with assuming htp_config_set_allow_space_uri in bundled libhtp

suricata-verify-pr: 691

OISF/suricata-verify#691

@catenacyber catenacyber requested a review from a team as a code owner January 28, 2022 11:29
@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #6884 (408a40c) into master (9e096dd) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #6884      +/-   ##
==========================================
+ Coverage   77.58%   77.73%   +0.14%     
==========================================
  Files         628      628              
  Lines      186922   186546     -376     
==========================================
- Hits       145019   145007      -12     
+ Misses      41903    41539     -364     
Flag Coverage Δ
fuzzcorpus 58.28% <100.00%> (+0.56%) ⬆️
suricata-verify 54.04% <100.00%> (+0.46%) ⬆️
unittests 63.23% <100.00%> (+0.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@pevma
Copy link
Member

pevma commented Feb 2, 2022

ERROR: QA failed on tlpr1_alerts_cmp

Pipeline: 5985

2 major deviations in alert counts
"2029216:3"
 base 3620 vs test 4934
"2807234:11"
 base 1006 vs test 1335

pcap to reproduce privately shared

@catenacyber
Copy link
Contributor Author

These deviations look like improvements to me after analysis if the pcap

@suricata-qa
Copy link

ERROR: QA failed on tlpr1_alerts_cmp.

Pipeline 6084

@pevma
Copy link
Member

pevma commented Feb 5, 2022

These deviations look like improvements to me after analysis if the pcap

Understood - thanks for checking it out !

@suricata-qa
Copy link

Warning: no commits in this PR have specified the following ticket(s):

Please update the commit(s) and submit a new PR.

@suricata-qa suricata-qa added the needs ticket Needs (link to) redmine ticket label Apr 26, 2022
@catenacyber
Copy link
Contributor Author

Replaced by #7318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs ticket Needs (link to) redmine ticket

Development

Successfully merging this pull request may close these issues.

4 participants