afpacket/netmap: warn about mixed ips, ids/tap deprecation - v2#8190
Closed
jasonish wants to merge 1 commit intoOISF:masterfrom
Closed
afpacket/netmap: warn about mixed ips, ids/tap deprecation - v2#8190jasonish wants to merge 1 commit intoOISF:masterfrom
jasonish wants to merge 1 commit intoOISF:masterfrom
Conversation
Suricata already logs if AF_PACKET or Netmap are running in a mixed IPS and IDS/TAP mode. As the behavior is undefined when these modes are mixed, it is best to deprecate and to not allow this behavior. For now warn that it will be unsupported and fail in Suricata 8. Ticket: 5587
| SCLogWarning(SC_ERR_INVALID_ARGUMENT, | ||
| "AF_PACKET using both IPS and TAP/IDS mode, this will not " | ||
| "be allowed in Suricata 8 due to undefined behavior. See " | ||
| "https://redmine.openinfosecfoundation.org/issues/5588"); |
Member
There was a problem hiding this comment.
See #5588 seems to the pattern we use in the code in other places. Shall I patch it up on merge?
Member
Author
There was a problem hiding this comment.
Ah, I found more usages of a full link. But my search was 'See ticket #'. Simply See #5888 is a bit ambiguous IMO.
Yes, please patch up on merge.
|
WARNING:
Pipeline 10717 |
Merged
Member
|
Merged in #8198, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suricata already logs if AF_PACKET or Netmap are running in a mixed IPS
and IDS/TAP mode. As the behavior is undefined when these modes are
mixed, it is best to deprecate and to not allow this behavior. For now
warn that it will be unsupported and fail in Suricata 8.
Ticket: 5587