Skip to content

afpacket/netmap: warn about mixed ips, ids/tap deprecation - v2 #8190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasonish wants to merge 1 commit into from
Closed

afpacket/netmap: warn about mixed ips, ids/tap deprecation - v2 #8190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/runmode-af-packet.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,7 +738,10 @@ int AFPRunModeIsIPS()
}

if (has_ids && has_ips) {
SCLogInfo("AF_PACKET mode using IPS and IDS mode");
SCLogWarning(SC_ERR_INVALID_ARGUMENT,
"AF_PACKET using both IPS and TAP/IDS mode, this will not "
"be allowed in Suricata 8 due to undefined behavior. See "
"https://redmine.openinfosecfoundation.org/issues/5588");
Copy link
Member

@victorjulien victorjulien Nov 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #5588 seems to the pattern we use in the code in other places. Shall I patch it up on merge?

Copy link
Member Author

@jasonish jasonish Nov 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I found more usages of a full link. But my search was 'See ticket #'. Simply See #5888 is a bit ambiguous IMO.

Yes, please patch up on merge.

for (ldev = 0; ldev < nlive; ldev++) {
const char *live_dev = LiveGetDeviceName(ldev);
if (live_dev == NULL) {
Expand Down
5 changes: 4 additions & 1 deletion src/runmode-netmap.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,10 @@ int NetmapRunModeIsIPS()
}

if (has_ids && has_ips) {
SCLogInfo("Netmap mode using IPS and IDS mode");
SCLogWarning(SC_ERR_INVALID_ARGUMENT,
"Netmap using both IPS and TAP/IDS mode, this will not be "
"allowed in Suricata 8 due to undefined behavior. See "
"https://redmine.openinfosecfoundation.org/issues/5588");
for (ldev = 0; ldev < nlive; ldev++) {
const char *live_dev = LiveGetDeviceName(ldev);
if (live_dev == NULL) {
Expand Down