Http2 decompression fixes 5691 v1#8194
Closed
catenacyber wants to merge 2 commits intoOISF:masterfrom
Closed
Conversation
It was not enough to set Cursor position to 0, also its inner Vec should be cleared. This way, a new input gets written at the beginning of the Cursor and its inner Vec... Ticket: OISF#5691
Contributor
Author
|
cc @dcbeckett |
|
WARNING:
Pipeline 10753 |
Merged
|
I've tested this PR against further flows and it fixes the issue |
Contributor
Author
|
Thanks for the feedback |
Member
|
Merged in #8198, thanks Philippe and thanks @dcbeckett ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5691
Should this ticket be split in 2 ? (for the 2 bugs in the 2 commits)
Describe changes:
suricata-verify-pr: 1007
OISF/suricata-verify#1007