Skip to content

userguide/install: add info on arch-based install#8789

Closed
JSkier21 wants to merge 1 commit intoOISF:masterfrom
JSkier21:patch-1
Closed

userguide/install: add info on arch-based install#8789
JSkier21 wants to merge 1 commit intoOISF:masterfrom
JSkier21:patch-1

Conversation

@JSkier21
Copy link
Contributor

@JSkier21 JSkier21 commented May 1, 2023

userguide/install: add info on arch-based install

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Describe changes:

  • Add ArchLinux based install information to documentation.

Add Arch AUR information for installation on Arch-based distros.
@JSkier21 JSkier21 requested a review from jufajardini as a code owner May 1, 2023 17:05
@inashivb inashivb requested a review from norg May 2, 2023 06:11
@jufajardini jufajardini added the typo/doc update No code change : only doc or typo fixes label May 2, 2023
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #8789 (e70d8dc) into master (22485b3) will decrease coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8789      +/-   ##
==========================================
- Coverage   82.18%   82.14%   -0.05%     
==========================================
  Files         969      969              
  Lines      272739   272739              
==========================================
- Hits       224164   224033     -131     
- Misses      48575    48706     +131     
Flag Coverage Δ
fuzzcorpus 64.16% <ø> (-0.13%) ⬇️
suricata-verify 60.32% <ø> (-0.04%) ⬇️
unittests 62.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, thanks for this contribution :)

Could you please adjust the commit message so it will comply with our commit guidelines?
In short, something like userguide/install: add info on arch-based install works. The commit body is fine.

For our documentation, we're also trying to keep lines at a 79/80 characters limit, following Sphinx/Rst suggestions.

@JSkier21 JSkier21 changed the title Update install.rst userguide/install: add info on arch-based install May 2, 2023
@catenacyber
Copy link
Contributor

@JSkier21 are you planning on addressing the requested changes ?

Copy link
Contributor Author

@JSkier21 JSkier21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ready to go?

@jufajardini
Copy link
Contributor

Should be ready to go?

We have to adjust character limit per line, and the commit message, but this is something that I can do, this time, if need be :)

@jufajardini
Copy link
Contributor

Should be ready to go?

We have to adjust character limit per line, and the commit message, but this is something that I can do, this time, if need be :)

Hey @JSkier21 do you want me to fix this one up?

@JSkier21
Copy link
Contributor Author

JSkier21 commented Jun 5, 2023

Should be ready to go?

We have to adjust character limit per line, and the commit message, but this is something that I can do, this time, if need be :)

Hey @JSkier21 do you want me to fix this one up?

Certainly please, if you don't mind. I haven't had time to delve into this much lately, but I'll try to take notes on what you do for next time 🙂

@jufajardini
Copy link
Contributor

Should be ready to go?

We have to adjust character limit per line, and the commit message, but this is something that I can do, this time, if need be :)

Hey @JSkier21 do you want me to fix this one up?

Certainly please, if you don't mind. I haven't had time to delve into this much lately, but I'll try to take notes on what you do for next time slightly_smiling_face

Ok, I'll submit a new PR with the preferred way, then you can compare and get a better idea of the guidelines ^^

@jufajardini
Copy link
Contributor

Changes requested incorporated in: #8972

@jufajardini jufajardini closed this Jun 5, 2023
@JSkier21
Copy link
Contributor Author

JSkier21 commented Jun 5, 2023

Should be ready to go?

We have to adjust character limit per line, and the commit message, but this is something that I can do, this time, if need be :)

Hey @JSkier21 do you want me to fix this one up?

Certainly please, if you don't mind. I haven't had time to delve into this much lately, but I'll try to take notes on what you do for next time slightly_smiling_face

Ok, I'll submit a new PR with the preferred way, then you can compare and get a better idea of the guidelines ^^

Much appreciated, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

typo/doc update No code change : only doc or typo fixes

Development

Successfully merging this pull request may close these issues.

3 participants