Skip to content

Comments

http: complete multipart data on open#8896

Closed
catenacyber wants to merge 1 commit intoOISF:masterfrom
catenacyber:multipart-mime-3487-v15.1
Closed

http: complete multipart data on open#8896
catenacyber wants to merge 1 commit intoOISF:masterfrom
catenacyber:multipart-mime-3487-v15.1

Conversation

@catenacyber
Copy link
Contributor

Link to redmine ticket:
preliminary work for https://redmine.openinfosecfoundation.org/issues/3487

Describe changes:

  • Fix HTTP multipart file open then truncate to consume as many bytes as possible

See #8886 QA run that produced this

By the way, I do not know when the file gets closed (to get a chance to add the bytes it missed)

Take as much as we can when opening, by making sure that the
boundary is not present
@catenacyber catenacyber requested a review from victorjulien as a code owner May 17, 2023 16:17
@catenacyber
Copy link
Contributor Author

SMTP QA difference for hash c23795ec4c575a0d0919aa2118c44db765aa88dc8e1375198255c45bd43d906c is also a difference of size 62814 in rust versus 61440 in current master

Do we want to fix these C versions ?

@suricata-qa
Copy link

ERROR:

ERROR: QA failed on SURI_TLPW1_files_sha256.

Pipeline 13818

@catenacyber
Copy link
Contributor Author

catenacyber commented May 18, 2023

Replaced by #8899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants