Closed
Conversation
jufajardini
requested changes
May 25, 2023
Contributor
jufajardini
left a comment
There was a problem hiding this comment.
Ok, I ran one last picky review, and submitted everything as suggestions, so, if you want, we can try to commit these and see if this version can be merged (IMO).
doc/userguide/devguide/codebase/contributing/github-pr-workflow.rst
Outdated
Show resolved
Hide resolved
doc/userguide/devguide/codebase/contributing/github-pr-workflow.rst
Outdated
Show resolved
Hide resolved
doc/userguide/devguide/codebase/contributing/github-pr-workflow.rst
Outdated
Show resolved
Hide resolved
doc/userguide/devguide/codebase/contributing/github-pr-workflow.rst
Outdated
Show resolved
Hide resolved
doc/userguide/devguide/codebase/contributing/github-pr-workflow.rst
Outdated
Show resolved
Hide resolved
doc/userguide/devguide/codebase/contributing/github-pr-workflow.rst
Outdated
Show resolved
Hide resolved
doc/userguide/devguide/codebase/contributing/github-pr-workflow.rst
Outdated
Show resolved
Hide resolved
doc/userguide/devguide/codebase/contributing/github-pr-workflow.rst
Outdated
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8926 +/- ##
==========================================
+ Coverage 82.30% 82.34% +0.04%
==========================================
Files 969 969
Lines 273335 273336 +1
==========================================
+ Hits 224961 225075 +114
+ Misses 48374 48261 -113
Flags with carried forward coverage won't be shown. Click here to find out more. |
…w.rst Co-authored-by: Juliana Fajardini Reichow <jufajardini@gmail.com>
…w.rst Co-authored-by: Juliana Fajardini Reichow <jufajardini@gmail.com>
…w.rst Co-authored-by: Juliana Fajardini Reichow <jufajardini@gmail.com>
…w.rst Co-authored-by: Juliana Fajardini Reichow <jufajardini@gmail.com>
…w.rst Co-authored-by: Juliana Fajardini Reichow <jufajardini@gmail.com>
…w.rst Co-authored-by: Juliana Fajardini Reichow <jufajardini@gmail.com>
…w.rst Co-authored-by: Juliana Fajardini Reichow <jufajardini@gmail.com>
…w.rst Co-authored-by: Juliana Fajardini Reichow <jufajardini@gmail.com>
Contributor
Author
|
Replaced by #8946 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
None
Describe changes:
Draft : to be discussed, and to see if the approved filter with
ghcommand is good enough ?Modifies #8925 by taking review into account