jsonbuilder: handle memory allocation errors - v6#8927
Closed
jasonish wants to merge 2 commits intoOISF:masterfrom
Closed
jsonbuilder: handle memory allocation errors - v6#8927jasonish wants to merge 2 commits intoOISF:masterfrom
jasonish wants to merge 2 commits intoOISF:masterfrom
Conversation
Some very minor changes to formatting.
Use try_reserve before growing the internal buffer, and the internal state vector. This allows allocation errors to be caught and an error returned instead of just aborting the process. Ticket: OISF#6057
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8927 +/- ##
==========================================
- Coverage 82.34% 82.34% -0.01%
==========================================
Files 969 969
Lines 273336 273377 +41
==========================================
+ Hits 225090 225100 +10
- Misses 48246 48277 +31
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 14071 |
This was referenced May 30, 2023
Closed
Closed
Merged
Member
|
Merged in #8945, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://redmine.openinfosecfoundation.org/issues/6057
Previous PR: #8916
Changes from previous PR: