Skip to content

mqtt: fix quadratic complexity#8940

Closed
catenacyber wants to merge 1 commit intoOISF:masterfrom
catenacyber:mqtt-quadra-v1
Closed

mqtt: fix quadratic complexity#8940
catenacyber wants to merge 1 commit intoOISF:masterfrom
catenacyber:mqtt-quadra-v1

Conversation

@catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6100

Describe changes:

  • mqtt: fix quadratic complexity

Background : I have been playing with some QuadraFuzz POC

get_tx_by_pkt_id loops only over the last transactions
in case there is a transaction flood

Ticket: OISF#6100
@catenacyber catenacyber requested a review from jasonish as a code owner May 30, 2023 10:14
@victorjulien
Copy link
Member

Windows CI issue fix 8988f35

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #8940 (5c6e1fc) into master (ebe0a7b) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8940      +/-   ##
==========================================
+ Coverage   82.30%   82.38%   +0.07%     
==========================================
  Files         969      969              
  Lines      273335   273336       +1     
==========================================
+ Hits       224961   225178     +217     
+ Misses      48374    48158     -216     
Flag Coverage Δ
fuzzcorpus 64.85% <100.00%> (+0.20%) ⬆️
suricata-verify 60.44% <100.00%> (-0.02%) ⬇️
unittests 62.95% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien victorjulien mentioned this pull request May 30, 2023
@suricata-qa
Copy link

WARNING:

field baseline test %
SURI_TLPR1_stats_chk
.flow.memuse 526058088 729695728 138.71%

Pipeline 14127

@victorjulien victorjulien mentioned this pull request May 31, 2023
@victorjulien
Copy link
Member

Merged in #8945, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants