source-pcap-file: include unlink error in warning message#8981
Closed
longdoan7421 wants to merge 1 commit intoOISF:masterfrom
Closed
source-pcap-file: include unlink error in warning message#8981longdoan7421 wants to merge 1 commit intoOISF:masterfrom
longdoan7421 wants to merge 1 commit intoOISF:masterfrom
Conversation
|
NOTE: This PR may contain new authors: |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8981 +/- ##
==========================================
- Coverage 82.42% 82.41% -0.01%
==========================================
Files 969 969
Lines 273476 273476
==========================================
- Hits 225410 225393 -17
- Misses 48066 48083 +17
Flags with carried forward coverage won't be shown. Click here to find out more. |
Member
|
CI failure is unrelated to the PR. |
victorjulien
previously approved these changes
Jun 7, 2023
Merged
Member
|
Merged in #8994, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
When
suricataruns with option--pcap-file-delete, in some cases it can be failed to delete the pcap files because of several reasons. However, the warning message does not give any hints regarding the cause of unsuccessful delete operation. Therefore, including error ofunlinkfunction in the warning message could be beneficial for debugging.Make sure these boxes are signed before submitting your Pull Request -- thank you.
Link to redmine ticket: N/A
Describe changes:
unlinkfunction's error in warning message when deleting pcap files failed.