windows: add -lntdll to fix windows builds#8988
Closed
jasonish wants to merge 1 commit intoOISF:masterfrom
Closed
Conversation
Rust 1.70 has introduced some possible issues between LLVM and gcc causing link errors that are fixed by explicitly adding -lntdll. Thanks to extendr/rextendr#285 for the fix.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8988 +/- ##
=======================================
Coverage 82.41% 82.41%
=======================================
Files 969 969
Lines 273556 273556
=======================================
Hits 225442 225442
Misses 48114 48114
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
approved these changes
Jun 7, 2023
Member
Author
|
This is needed in |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust 1.70 has introduced some possible issues between LLVM and gcc
causing link errors that are fixed by explicitly adding -lntdll.
Thanks to extendr/rextendr#285 for the fix.