Skip to content

Comments

Output alert applayer v13.2#9799

Closed
catenacyber wants to merge 7 commits intoOISF:masterfrom
catenacyber:output-alert-applayer-v13.2
Closed

Output alert applayer v13.2#9799
catenacyber wants to merge 7 commits intoOISF:masterfrom
catenacyber:output-alert-applayer-v13.2

Conversation

@catenacyber
Copy link
Contributor

Link to redmine tickets:
https://redmine.openinfosecfoundation.org/issues/3827
https://redmine.openinfosecfoundation.org/issues/5977
https://redmine.openinfosecfoundation.org/issues/6500
https://redmine.openinfosecfoundation.org/issues/6501
preliminary work for https://redmine.openinfosecfoundation.org/issues/5053 and app-layer plugins

Describe changes:

  • Fix setup-app-layer script so that it adds app-layer metadata to alerts
  • add krb5 metadata to alerts
  • add ftp metadata to alerts
  • add tftp metadata to alerts

#9797 with more commits

SV_BRANCH=pr/1465

OISF/suricata-verify#1465

Draft : CI will fail because of BitTorrent named bittorrent-dht with a dash as a protocol, but event_type is bittorrent_dht with an underscore. @jasonish does this need harmonization ?
(there is the same thing for ftp-data protocol having ftp_data events)

catenacyber and others added 7 commits November 16, 2023 10:01
Especially fix setup-app-layer script to not forget this part

This allows, for simple loggers, to have a unique definition
of the actual logging function with the jsonbuilder.
This way, alerts, files, and app-layer event can share the code
to output the same data.

Ticket: OISF#3827
@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 16555

@catenacyber
Copy link
Contributor Author

Draft : CI will fail because of BitTorrent named bittorrent-dht with a dash as a protocol, but event_type is bittorrent_dht with an underscore. @jasonish does this need harmonization ? (there is the same thing for ftp-data protocol having ftp_data events)

See https://redmine.openinfosecfoundation.org/issues/6502

Meanwhile, we can play with #9807

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants