Skip to content

Output alert applayer v16.1#9869

Closed
catenacyber wants to merge 4 commits intoOISF:masterfrom
catenacyber:output-alert-applayer-v16.1
Closed

Output alert applayer v16.1#9869
catenacyber wants to merge 4 commits intoOISF:masterfrom
catenacyber:output-alert-applayer-v16.1

Conversation

@catenacyber
Copy link
Contributor

Link to redmine tickets:
https://redmine.openinfosecfoundation.org/issues/3827
Preliminary work for https://redmine.openinfosecfoundation.org/issues/5053

Describe changes:

  • output: unify boilerplate code (trying to become a lines-of-code neutral contributor to Suricata ;-) and rising the percentage of rust files )
  • output/dns: do not add empty app-layer metadata
  • app-layer: do not require probing parser as fixed patterns can be enough
  • dnp3: restrict function scope to one file

Follow up after large of #9851 (part of #9812 for app-layer plugins)

@jasonish what do you think about the DNS commit ?

Should I split this into multiple PRs ?

@catenacyber
Copy link
Contributor Author

Replaced by #9870

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments