Closed
Conversation
Even when on detection-only mode. So that we always have enip_tcp and enip_udp in stats and never just `enip`. Suricata needs to know beyond suricata.yaml configuration which protocols can be enabled on both tcp and udp... Ticket: 6304
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9934 +/- ##
==========================================
- Coverage 82.35% 82.31% -0.04%
==========================================
Files 972 972
Lines 273060 273067 +7
==========================================
- Hits 224870 224788 -82
- Misses 48190 48279 +89
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
requested changes
Dec 1, 2023
Member
victorjulien
left a comment
victorjulien
left a comment
There was a problem hiding this comment.
I don't like adding this kind of hard coded logic. Would like to see it work based on how protocols are registered, otherwise it will be yet another thing that a new protocol will need to update.
|
Information: QA ran without warnings. Pipeline 16816 |
Contributor
Author
Agreed Replaced by #9942 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6304
Describe changes:
First commit of #9850 which deserves its own PR