Closed
Conversation
Even when on detection-only mode. So that we always have enip_tcp and enip_udp in stats and never just `enip`. Ticket: 6304
./stats/app_layer/error/modbus
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #9953 +/- ##
==========================================
+ Coverage 82.35% 82.45% +0.10%
==========================================
Files 972 970 -2
Lines 273060 271361 -1699
==========================================
- Hits 224870 223762 -1108
+ Misses 48190 47599 -591
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 16853 |
victorjulien
approved these changes
Dec 13, 2023
Contributor
Author
|
S-V PR has been updated to OISF/suricata-verify#1546 Should I rebase this Suricata PR to match it ? |
Member
I've restarted the actions after updating the reference here, we'll see if it passes. Both suricata and SV have been updated since, so rebase may be required. |
Contributor
Author
Done in #10050 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6304
Describe changes:
#9946 without variable name shadowing
OISF/suricata-verify#1546