Add compliance validation pipeline for imported game catalog#1
Closed
aqplemine wants to merge 1 commit into
Closed
Add compliance validation pipeline for imported game catalog#1aqplemine wants to merge 1 commit into
aqplemine wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
scripts/validate/validate_catalog.pyto validate required fields (id,title,source_url,source_license,source_license_status,attribution_required,redistribution_rights), capturesource_licenseandattribution_required, detect duplicateids, and reject blocked license states.manual_approval=truefor entries withredistribution_rightsofunknownormissing, otherwise block them.DEFAULT_ALLOWLIST_HOSTS) and suspicious host detection (punycode, known shorteners, malware/phish patterns, IP-literals, credential-in-URL) that block offendingsource_urls.data/reports/compliance-report.mdsummarizing totals and issues for each run.scripts/validate/build_catalog.pyas a simple wrapper to run the validator during catalog builds..github/workflows/compliance-validation.ymlto run validation onpush/pull_requestagainstmainand a baselinedata/catalog/imported-games.jsonfile for the validator entrypoint.Testing
python scripts/validate/build_catalog.pywhich executed the validator and printed:Compliance validation passed (0 entries).and wrote the report, indicating success.python scripts/validate/validate_catalog.py data/catalog/imported-games.json --report-path data/reports/compliance-report.mdwhich also succeeded and generateddata/reports/compliance-report.md..github/workflows/compliance-validation.yml) to enforce the same checks on push/PR (workflow not executed here).Codex Task