Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ola FIS10 Log Submission #1871

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

deepesh2008
Copy link

No description provided.

@sourabhsaini11
Copy link

sourabhsaini11 commented Dec 30, 2024

@deepesh2008
BAP issues:
common_issues

  • ⁠invalid billing.address

confirm

  • missing code for the list items provided in SETTLEMENT_DETAILS tag-group, missing other tags for the same, as well as missing BUYER_FINDER_FEES at payment.tags

Flow-3
on_update

  • payload is missing item cancellation

@92shreyansh 92shreyansh added the FIS-10 Gift Cards label Dec 31, 2024
@sourabhsaini11
Copy link

@deepesh2008
BPP Issues:
on_search

  • missing ITEM_DETAILS at items[0]
  • descriptor.images should contain url attribute

on_confirm, on_status

  • for fulfillments.state PENDING, stops.authorization shouldn't be present
  • missing id & params at payments
  • ⁠missing SETTLEMENT_DETAILS tag-group(on_i)

on_cancel, on_update

  • ⁠missing SETTLEMENT_DETAILS tag-group

common_issues

  • for title "ITEM", missing item.price.offered_value at quote.breakup

@deepesh2008
Copy link
Author

payload is missing item cancellation:
The payload submitted I received from Pramaan while executing flow 3.
I have not received the respective status as required to fulfil the need, plz suggest how to proceed.
@sourabhsaini11
Regarding Action received from seller we discussed as Buyer we cant do any thing please suggest to proceed forward.

@deepesh2008
Copy link
Author

deepesh2008 commented Dec 31, 2024

offered_value and value added under the quote.breakup.item.price in confirm call @sourabhsaini11
![image](https://github.com/user-attachments/ass
Screenshot 2024-12-31 at 5 44 45 PM
ets/f332d074-6be8-4b08-b32f-8b5484f3dd81)

@sourabhsaini11
Copy link

@deepesh2008
Flow3_partial_cancellation
on_update

  • call doesn't contain cancellation part

  • BAP logs cleared.

@simranOndc
Copy link

@Ashu-14-oct @Nirdosh3312 Pick and close all the on_action call issues.

Deepesh Jain added 2 commits January 13, 2025 20:12
Adding Ola Gift Card Pramaan test Flow execution test report.
Adding Ola Gift Card Test Report generated via Pramaan Beta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FIS-10 Gift Cards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants