USGI PRE-PROD LOG

[shivadotnetcode]

USGI have completed Pre prod environment for Two Wheeler Motor insurance product for NEW and Transfer.
Below are the stage completed as of now
FLOW 1
FLOW 2
FLOW 3
FLOW 4

[gitguardian]

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
-	-	Generic Password	0706d35	FIS13/USGI/FLOW_4/confirm_1_Response.json	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secret safely. Learn here the best practices.
3. Revoke and rotate this secret.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

[sourabhsaini11]

@shivadotnetcode
common_issues

• BASE_PRICE should be same as item.price
• TAX should be same as what was sent in on_search(2)
• quote.breakup summation should match quote.price
• params.amount should be same as quote.price
• invalid format for tags DEPRECIATION_COVER, CONSUMABLES_COVER, EXTERNAL_CNG_OR_LPG_COVER, KEY_COVER (bool)
• created_at must match on_confirm call's created_at

search_1

• remove attribute provider

on_search_1

• invalid tags present in GENERAL_INFO tag-group, should be as per api-contract
• How can item.id be same as api-contract

search_2

• missing bpp_id & bpp_uri

- multiple item objects can't be selected

on_search_2

• invalid tags present in GENERAL_INFO tag-group, should be as per api-contract
• value in invalid format for tag OFFER_VALIDITY, should be P15D instead
• value should be precise upto 2decimal places (IDV_MIN_VALUE, IDV_MAX_VALUE)
• How can item.id be same as api-contract

select

• remove attribute xinput

on_select

• code RETURN_TO_INVOICE(2925) & item.price(21386) value are changed from what was sent in past on_action
• PREVIOUS_POLICY_END_DATE should be in YYYY-MM-DD format

select

• remove attribute items.tags

init

• remove null attributes
• type & status in payment can't be null
• missing SETTLEMENT_TYPE & SETTLEMENT_AMOUNT at SETTLEMENT_TERMS
• missing id at fulfillments(/init_2 only)

on_init

• missing VAHAN_DETAILS tag-group at items
• head.descriptor value can't be "Personal Details"
• missing SETTLEMENT_TYPE & SETTLEMENT_AMOUNT at SETTLEMENT_TERMS

confirm

• missing tags

on_confirm

• created_at & updated_at can't be greater than timestamp
• missing person.name at fulfillments
• missing SETTLEMENT_TYPE & SETTLEMENT_AMOUNT at SETTLEMENT_TERMS

Payemnt_Request

• invalid request/JSON

Payment_Response

• file name should be on_status

• created_at & updated_at are missing

• timestamp should be greater than on_confirm' timestamp

• missing SETTLEMENT_TYPE & SETTLEMENT_AMOUNT at SETTLEMENT_TERMS

• How can fulfillments.id be same as api-contract

Flow CLAIM

• invalid requests ON_UPDATE_CLAIM_Request, remove them & similar looking files

on_update

• missing person.name at fulfillments
• for code REQUESTED_CLAIM_AMOUNT, APPROVED_CLAIM_AMOUNT valid value shall be sent
• missing SETTLEMENT_TYPE & SETTLEMENT_AMOUNT at SETTLEMENT_TERMS

ON_UPDATE_CLAIM_3_Response

• action should be of on_status instead of on_update here

Flow CANCEL

• invalid requests ON_UPDATE_CLAIM_Request, remove them & similar looking files

on_update

• missing person.name at fulfillments
• missing SETTLEMENT_TYPE & SETTLEMENT_AMOUNT at SETTLEMENT_TERMS

[sourabhsaini11]

@shivadotnetcode, it's a gentle reminder to provide updated logs.

[sourabhsaini11]

@shivadotnetcode, kindly provide updated transactional logs as well

[shivadotnetcode]

@sourabhsaini11 , We have uploaded Pre prod transaction log and resolved all the points .Request you to please reverify all the flow of transaction as well as IGM .

[amitsinha07]

@shivadotnetcode

Feedbacks for IGM

On_issue

• "org_name": Organization's Name for /on_issue API in message/issue/issue_actions/respondent_actions/[0] mismatched with BPP ID.
• "updated_at": The updated_at of message/issue/issue_action/respondent_actions/index[0]/updated_at should be the same as or less than message/issue/update_at in on_issue.

On_issue_status

• "refund_amt": Refund Amount for /on_issue_status should only be present when the action type is REFUND.
• "org_name": Organization's Name for /on_issue_status API in message/issue/issue_actions/respondent_actions/[0] mismatched with BPP ID.
• message/issue/issue_action/respondent_actions/index[0]/updated_at should be the same as or less than message/issue/update_at in on_issue_status.
• Message/issue/updated_at should not match with Message/issue/created_at.
• Message/issue/issue_action/respondent_actions/index[0]/updated_at should match with
  message/issue/issue_action/respondent_actions/index[0]/updated_at of the on_issue call.
• Respondent action "Resolved" is missing as the resolution_provider is given.

[sourabhsaini11]

@shivadotnetcode
common_issues

• tag SETTLEMENT_AMOUNT value is incorrect.

search

• remove attributes having null values

on_search

• tags SETTLEMENT_AMOUNT & SETTLEMENT_TYPE are sent additionally

on_search_2

• add_ons price is changed from what was sent in on_search_1 for item.id USGI

search_2

• missing bpp_id & bpp_id

select

• remove attributes having null values

on_select_1

• item.price for item.id 'CHILD_ITEM_USGI_I01' is changed from what was sent in past call

on_select

• tags PREVIOUS_POLICY_NUMBER, PREVIOUS_INSURER & PREVIOUS_POLICY_END_DATE are missing in VAHAN_DETAILS

init

• remove attributes having null values
• bank_account_number, currency, bank_code, type & status can't be null at payments

init_2

• id is missing in fulfillments

confirm

• category_ids are sent additionally
• payment.tags sent are wrong, kindly refer to api-contract once

on_update

• created_at should match past call's created_at
• How can order.id, GENERAL_INFO tags value be changed b/w on_confirm & on_update
• fulfillment[1].customer.person is not required

on_cancel

• created_at should match past call's created_at
• updated_at can't be greater than context.timestamp
• missing fulfillment.customer.person

[shivadotnetcode]

Hi Amit ,
We have resolved all the IGM highlighted point.
Request you to please Review and confirm.

[shivadotnetcode]

on_update (LOG SUBMITTED)

1. created_at should match past call's created_at (USGI comments :- Not possible because it may differ.)
2. How can order.id, GENERAL_INFO tags value be changed b/w on_confirm & on_update (USGI comments :- Resolved)
3. fulfillment[1].customer.person is not required (USGI comments :- Resolved)

on_cancel (LOG SUBMITTED)

1. created_at should match past call's created_at (USGI comments :- Not possible because it may differ.)
2. updated_at can't be greater than context.timestamp (USGI comments :- Resolved)
3. missing fulfillment.customer.person (USGI comments :- Resolved)

Please find highlighted comments against each points and for that we required some discussion. As per logic we think it was correct which are passed as per ONDC flow.

common_issues

tag SETTLEMENT_AMOUNT value is incorrect. (USGI comments :- What should need to pass currently passing Zero. Please confirm the logic)

search
remove attributes having null values ((USGI comments :- Not at USGI end.)

on_search
tags SETTLEMENT_AMOUNT & SETTLEMENT_TYPE are sent additionally (USGI comments :- Resolved)

on_search_2
add_ons price is changed from what was sent in on_search_1 for item.id USGI

(USGI comments :- In search_1 response we are passing only catalogue information with default values (Already discussed with Mohit) in Search_2 we are calculating the premium based on user entered IDV value from FORM1 page. This has already been discussed in team call with mohit and nivesh team.

search_2
missing bpp_id & bpp_id (USGI comments :- Not at USGI end.)

select
remove attributes having null values (USGI comments :- Not at USGI end.)

on_select_1
item.price for item.id 'CHILD_ITEM_USGI_I01' is changed from what was sent in past call

(USGI comments :- In search_2 response we are passing premium based on FORM1 entered IDV value for all available Adon at USGI end and after user selection of addon category then we recalculating the premium based on selected addon in select1 call . So as per logic amount get changed in selec_1 response from insurer side.)

on_select
tags PREVIOUS_POLICY_NUMBER, PREVIOUS_INSURER & PREVIOUS_POLICY_END_DATE are missing in VAHAN_DETAILS

(USGI comments :- As checked above tag is available in FLOW2 (Rollover and transfer case). In New business case. Above tag was not applicable.

init
remove attributes having null values (Request coming from Praman portal.This is not in USGI end.)
bank_account_number, currency, bank_code, type & status can't be null at payments

USGI comments :- (USGI comments :- Not at USGI end.)

init_2
id is missing in fulfillments (USGI comments :- Not at USGI end.)

confirm
category_ids are sent additionally (Request coming from Praman portal.This is not in USGI end.)
payment.tags sent are wrong, kindly refer to api-contract once
((USGI comments :- (USGI comments :- Not at USGI end.)

Dear Team requests you to please arrange a team call with sourabhsaini11 or share the contact number so that we can discuused if there is any understaning required related to process flow .

[amitsinha07]

@shivadotnetcode

On_issue

• Message/issue/issue_action/respondent_actions/0/updated_by/org/name - Domain name is missing.
• Created_at in issue call is mismatched with created_at in on_issue call.

On_issue_status

• Created_at in on_issue_status call is mismatched with created_at in issue call.
• Context timestamp should be greater than or equal to updated_at in on_issue_status.
• Message/issue/issue_action/respondent_actions/0/updated_by/org/name - Domain name is missing.
• Message/issue/issue_action/respondent_actions/1/updated_by/org/name - Domain name is missing.
• Message/issue/resolution_provider/respondent_info/organization/org/name - Domain name is missing.

[sourabhsaini11]

@shivadotnetcode
on_search

• for add_ons ROAD_SIDE_ASSISTANCE, descriptor.code should not be sent, only descriptor.name
• add_ons CONSUMABLES_COVER, DEPRECIATION_COVER, KEY_COVER, TYRE_COVER, RETURN_TO_INVOICE, DAILY_ALLOWANCE price is changed b/w on-on_search_1 & on_search_2 for items[0]

on_select_2

• mime_type should be text/html

on_init

• mime_type should be text/html

on_confirm

• missing price from add_ons

on_update

• bpp_uri & some of GENERAL_INFO tags value are changed b/w on_confirm & on_update
• created_at should match past call's created_at

on_status

• created_at should match past call's created_at

on_cancel

• created_at should match past call's created_at

[shivadotnetcode]

Hi Amit,

We have reuploaded the IGM log. please reverify once and confirm

[shivadotnetcode]

Hi ,sourabhsaini11
We have some query on your updated comments related flow1/flow4/flow3/flow4 .
we have already discussed this with Amit kumar and he suggested he will ask you to join on team meet or goggle meet.
Request you to please share or mail to us with team meet link at earliest.
my contact number :- 9987995659 official email :- [email protected]

[amitsinha07]

@shivadotnetcode

Logs are approved for IGM 1.0

[shivadotnetcode]

Dear sourabh,
Today, we have re-uploaded the transaction log for Process Flow 1, 2, 3, and 4. Kindly reverify and confirm.

Please find below comments related to feedback points.

Addon Prices in Different Searches (Search_1, Search_2, Select_1):

1. Search_1: In this stage, the seller provides the buyer with a catalogue of available add-ons and covers, along with default values. The price displayed here is based on the default add-ons and covers from the seller's side.
2. Search_2: In this search, the seller calculates the price based on the default add-ons and covers that were passed in the Search_1 response. These default values have already been provided by the seller to the buyer.
3. Select_1: After the buyer selects the add-ons and covers, the seller recalculates the item price based on these selections. The seller will provide a quote, and the addon price will be adjusted accordingly. This is why the addon price changes during the On_Select_1 response, based on the buyer's choices.

2. (USGI comments :- Request you to provide the feedback with flow wise related to Seller side only because we are from seller side as insurance provider.below points are not related to seller side.
   • search remove attributes having null values
   • search_2 missing bpp_id & bpp_id
   • select remove attributes having null values
   • init remove attributes having null values
   • init_2 id is missing in fulfillments

[sourabhsaini11]

@shivadotnetcode
on_select

• BASE_PRICE, TAX & add_ons A6 price are changed from what was sent in on_search_2

on_confirm

• missing add_ons.price

unsolicited_On_status_payment

• How can created_at & updated_at be present before order creation
• item.fulfillment_ids referred is incorrect

unsolicited_On_staus_eKyc, unsolicited_On_staus_manual_review

• item.fulfillment_ids referred is incorrect

unsolicited_On_status_update_claim

• additional attribute customer.person found at fulfillments[1]

On_update_claim_1

• created_at should match past call's created_at

on_cancel

• created_at should match past call's created_at

[shivadotnetcode]

@sourabhsaini11 ,

We have resolved the highlighted feedback points and uploaded on ONDC verify GitHUb .
Request you to reverify and confirm.

[shivadotnetcode]

Dear Sourabh,

As discussed in today’s team call with Mohit, we agreed on the following logic regarding the feedback comments.

On_Select:
• The BASE_PRICE, TAX, and Add_ons A6 price have changed compared to the values sent in the on_search_2 API call.

USGI Comments:

• If the IDV value changes between the ONsearch_2 and On_Select1 API calls, the Premium will also change, which aligns with the expected logic.
As a result, the BASE_PRICE, TAX, and Add_ons A6 price values in the OnSelect1 response were different from those in the on_search_2 response.

[sourabhsaini11]

@shivadotnetcode
on_confirm

• missing add_ons.price

[sourabhsaini11]

@shivadotnetcode, transactional-logs cleared.

[shivadotnetcode]

@shivadotnetcode, transactional-logs cleared.

THANKS a lot..