Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Org name as ChooseApp in TRV10 folder: #1883

Open
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

Shaikh-Dilshad
Copy link

  • Added pramaan flow 1a , flow 1b and flow 2 logs
  • please look these 3 logs i will upload other logs later

@92shreyansh 92shreyansh added the TRV-10 Ride Hailing Services label Jan 8, 2025
@Shaikh-Dilshad
Copy link
Author

@92shreyansh is my logs are verified? but its not showing in the TRV10 folder

* Added Flow 3-Merchant Side Full Order Cancellation logs
* Added Flow 4-Technical Cancellation (Negative Scenario- TTL is expired, Status , Cancel) logs
* Added Flow 5-Journey Updation (This may include Payment, Fare) logs
* Added Flow 6- Order to Confirm (assign driver post on_confirm) (Self Pickup) logs

Kindly please let me know is my previous logs is verified?
* Added Flow 7a-Order to Confirm (driver not found on on_confirm)
* Added flow b
* Added rsf logs flow 1 , flow 2 and flow 3 will be adding others later
@Shaikh-Dilshad
Copy link
Author

  1. Added other pramaan logs TRV10 Flows logs:
  • Added Flow 3-Merchant Side Full Order Cancellation logs
  • Added Flow 4-Technical Cancellation (Negative Scenario- TTL is expired, Status , Cancel) logs
  • Added Flow 5-Journey Updation (This may include Payment, Fare) logs
  • Added Flow 6- Order to Confirm (assign driver post on_confirm) (Self Pickup) logs
  • Added Flow 7a-Order to Confirm (driver not found on on_confirm)
  • Added flow b
  1. Added RSF logs
  • flow 1 , flow 2 and flow 3 will be adding others later

@sourabhsaini11
Copy link

@Shaikh-Dilshad
common_issues

  • on_action calls timestamp should be greater than action call's timestamp
  • gps at fulfillment.stops should be precise upto 6 decimal places
  • incorrect format for tag SETTLEMENT_WINDOW, value should be P1D instead
  • SETTLEMENT_AMOUNT should be calculated by deducting Buyer finder fee from total quote price
  • your bap_id is not reflecting when checked at pre-prod env registry. please reupload the logs with correct registered bap_id.

confirm

  • missing payment.params

on_confirm

  • authorization.stops shouldn't be present when the driver is not assigned at /on_confirm.
  • tag DELAY_INTEREST, COURT_JURISDICTION, SETTLEMENT_AMOUNT & SETTLEMENT_WINDOW value mismatch b/w action & on_action calls

on_status

  • message_id mismatch against status's message_id

on_cancel(soft)

  • missing order.cancellation

Flow-4
cancel

  • cancellation_reason_id should be 0 for technical cancellation

Flow-6 & 7
on_search

  • missing fulfillments with type Self-Pickup while flow represents the same

@Shaikh-Dilshad
Copy link
Author

@sourabhsaini11

  1. on_action calls timestamp should be greater than action call's timestamp
    -> actually we are buyer and in these log seller is pramaan so the on action is from pramaan in that i can't do anything

And on_action is from pramaan saurabh i can't do anything in that other then whatever the issues related to action i will solve that

@Shaikh-Dilshad
Copy link
Author

@sourabhsaini11 below is my lookup api response see we are subscribed in pre-prod

{
"subscriber_id": "backend.choosecabs.com",
"status": "SUBSCRIBED",
"ukId": "66fe660998f25",
"subscriber_url": "https://backend.choosecabs.com/api/trv10",
"country": "IND",
"domain": "ONDC:TRV10",
"valid_from": "2024-12-11T13:44:54.101Z",
"valid_until": "2030-06-19T11:57:54.101Z",
"type": "BAP",
"signing_public_key": "sgJgGe3xh8pdYoj5NrUuzKhx4h9P//UOY3jWtH5xz/M=",
"encr_public_key": "MCowBQYDK2VuAyEAN683ZAgZUgv2n3xs8kLovdswU7Wbd39RrEVUBU0pZxE=",
"created": "2024-12-11T11:26:52.374Z",
"updated": "2024-12-11T11:26:52.381Z",
"br_id": "66fe660998f25",
"city": "std:022"
}

* Modified the all logs according reviews
… (assign driver post on_confirm)/status.json
* modified the logs
* modified the logs
@Shaikh-Dilshad
Copy link
Author

@sourabhsaini11
All FLows Modified:

  • modified the logs as per review
  • as buyer i made changes only on action not on on_action because the on_action is coming from pramaan
  • i have added response from lookup and we are subscribed on pre prod please do check

* Added complete payload of  settle and report
* Added complete payload of settle and report
 * Added rsf - Miscellaneous fund movement/
* Added rsf  Nil settlement
@Shaikh-Dilshad
Copy link
Author

RSF folder modified:

  • Added RSF flow 4 Miscellaneous fund movement
  • Added RSF flow 5 Nil settlement

@Shaikh-Dilshad
Copy link
Author

@sourabhsaini11 @92shreyansh
Uploaded the flows logs and RSF logs please do check

@sourabhsaini11
Copy link

@Shaikh-Dilshad
common_issues

  • on_action calls timestamp should be greater than action call's timestamp
  • tags DELAY_INTEREST, COURT_JURISDICTION, SETTLEMENT_AMOUNT value mismatch b/w action on_action calls

@Shaikh-Dilshad
Copy link
Author

@sourabhsaini11
As i mentioned in previous PR that we are buyer and its seller (pramaan) issue who is sending the on_action . our job is to send only action

@Shaikh-Dilshad
Copy link
Author

@sourabhsaini11 @92shreyansh
Please do check the logs saurabh in on_action we can't do anything on that this was from pramaan we are buyer only seller is pramaan

@Shaikh-Dilshad
Copy link
Author

IGM2.0 LOGS modified:

  • reuploaded the issue_close json

* re uploaded the rsf logs as per review
@Shaikh-Dilshad
Copy link
Author

@JyotiSharma0711
Re Uploaded The RSF logs please do check

@amitsinha07
Copy link

amitsinha07 commented Jan 23, 2025

@Shaikh-Dilshad

IGM Feedbacks

issue_status and on_issue_status call is missing

Please resubmit your logs

@Shaikh-Dilshad
Copy link
Author

@amitsinha07
iGM2.0 preprod is not completely develop yet so amit from daily dev call told me that issue_status is optional i can skip that

@amitsinha07
Copy link

@Shaikh-Dilshad

You are correct about the issue_status and on_issue_status calls. However, your flow is incomplete, as the issue cannot be resolved in just one call. Please review the API contract and provide the flow accordingly.

@JyotiSharma0711
Copy link

TRV10/ChooseApp/RSF

Flow 1

Settle

message/settlement/orders/0/collector/amount/value - Format should be in ^\d+.\d{2}$.

Settle and On_settle

context/version - Incorrect version, expected 2.0.1.
collector_app_id - "collector_app_id should not match with bpp_id"

Report and On_report

context/version - Incorrect version, expected 2.0.1.
On_report

  • collector_app_id - "collector_app_id should not match with bpp_id"

Flow 2

Recon

context/version - Incorrect version, expected 2.0.1.
message/orders/0/settlements/0/status - Must be one of the allowed values: PENDING, SETTLED, TO-BE-INITIATED.

On_recon

context/version - Incorrect version, expected 2.0.1.
message/orders/due_date - Object field is missing.
message/orders/0/recon_accord - Must be boolean.
message/orders/0/settlements/0/status - Must be one of the allowed values: PENDING, SETTLED, TO-BE-INITIATED.
"Settlement updated_at timestamp cannot be greater than context timestamp."


Flow 3

Recon

context/version - Incorrect version, expected 2.0.1.
message/orders/0/settlements/0/status - Must be one of the allowed values: PENDING, SETTLED, TO-BE-INITIATED.

On_recon

context/version - Incorrect version, expected 2.0.1.
message/orders/due_date - Object field is missing.
message/orders/0/recon_accord - Must be boolean.
"Settlement updated_at timestamp cannot be greater than context timestamp."


Flow 4

Settle and On_settle

context/version - Incorrect version, expected 2.0.1.


Flow 5

Settle and On_settle

context/version - Incorrect version, expected 2.0.1.

@Shaikh-Dilshad
Copy link
Author

@JyotiSharma0711
i checked the logs its 2.0.1 version and about the collector_app_id the payment is going to be collect by bpp collector will be bpp then right?

on_recon is sent by mock server

@Shaikh-Dilshad
Copy link
Author

@JyotiSharma0711 i just saw the contract there will be NBBL bpp id and bpp_uri right and collector_app_id will collector id right? can you please confirm this. and please do check ragarding the version i have the checked the submitted logs seams there is 2.0.1

@Shaikh-Dilshad
Copy link
Author

@amitsinha07 Uploaded IGM flow please do check

@Shaikh-Dilshad
Copy link
Author

@92shreyansh @sourabhsaini11
Please do check my uploaded basic flows

* uploaded the all logs as per review
* add logs conain version 2.01
@Shaikh-Dilshad
Copy link
Author

@JyotiSharma0711
Re Uploaded the RSF logs please do check

@JyotiSharma0711
Copy link

TRV10/ChooseApp/RSF (2)

(common errors)**
Error:

  • context/version is wrong, expected version is 2.0.0.

@Shaikh-Dilshad
Copy link
Author

@JyotiSharma0711 you told me again and again that expected version is 2.0.1 kindly look in previous review

@Shaikh-Dilshad
Copy link
Author

@JyotiSharma0711 can i just edit it out the version because my flow is correct right? only the version issue and you are the one who told me in previous review that expected 2.0.1 and its minor changes i will do it in my end please approve the logs

@JyotiSharma0711
Copy link

Hi @Shaikh-Dilshad due to misinterpretation of log validation message it tends to be mistake on my end Please update the logs again with valid version 2.0.0

* update the version
@Shaikh-Dilshad
Copy link
Author

Hi @JyotiSharma0711 Updated the logs with the valid version please do check

@JyotiSharma0711
Copy link

Logs approved for RSF 2.0.0

@Shaikh-Dilshad
Copy link
Author

@sourabhsaini11 @92shreyansh
its been a week since i have uploaded the logs please do check we need to move forward

@amitsinha07
Copy link

@Shaikh-Dilshad

Feedbacks for IGM

ISSUE(1)

  • Context/ttl - Should be "P30S" according to the API contract.

ON_ISSUE(2)

  • Context/core_version - Object field is missing.
  • Context/ttl - Should be "P30S" according to the API contract.
  • Message/issue/actors/2/info/org/name - Mismatched with bpp_id.
  • Message/issue/actors/2/info/org/name-domain - Mismatched with context/domain.
  • issue/updated_at - Missing.

ON_ISSUE(3)

  • Context/core_version - Object field is missing.
  • Context/ttl - Should be "P30S" according to the API contract.
  • Message/issue/actors/2/info/org/name - Mismatched with bpp_id.
  • Message/issue/actors/2/info/org/name-domain - Mismatched with context/domain.
  • issue/updated_at - Missing.
  • issue/created_at - Missing.

ISSUE(4)

  • Context/ttl - Should be "P30S" according to the API contract.
  • Message/issue/created_at - Mismatched with Message/issue/created_at in the “issue” call.
  • Message/issue/created_at - Should be less than issue/updated_at.

ON_ISSUE(5)

  • Context/core_version - Object field is missing.
  • Context/ttl - Should be "P30S" according to the API contract.
  • Message/issue/actors/2/info/org/name - Mismatched with bpp_id.
  • Message/issue/actors/2/info/org/name-domain - Mismatched with context/domain.
  • issue/updated_at - Missing.
  • issue/created_at - Missing.

ON_ISSUE(6)

  • Context/core_version - Object field is missing.
  • Context/ttl - Should be "P30S" according to the API contract.
  • Message/issue/actors/2/info/org/name - Mismatched with bpp_id.
  • Message/issue/actors/2/info/org/name-domain - Mismatched with context/domain.
  • issue/updated_at - Missing.
  • issue/created_at - Missing.

ISSUE(7)

  • Context/ttl - Should be "P30S" according to the API contract.
  • Message/issue/created_at - Mismatched with Message/issue/created_at in the “issue” call.
  • Message/issue/created_at - Should be less than issue/updated_at.

ON_ISSUE(8)

  • Context/core_version - Object field is missing.
  • Context/ttl - Should be "P30S" according to the API contract.
  • Message/issue/actors/2/info/org/name - Mismatched with bpp_id.
  • Message/issue/actors/2/info/org/name-domain - Mismatched with context/domain.
  • issue/updated_at - Missing.
  • issue/created_at - Missing.

ISSUE(8)

  • Context/ttl - Should be "P30S" according to the API contract.
  • Message/issue/created_at - Mismatched with Message/issue/created_at in the “issue” call.
  • Message/issue/actions/8/tages/0/list/0/value - Not in the correct format, should be "THUMB-UP".
  • Message/issue/created_at - Should be less than issue/updated_at.

* Added new logs of IGM please do check
@Shaikh-Dilshad
Copy link
Author

@amitsinha07
I have uploaded the IGM2.0. Please check and review it. As we discussed in the meeting, you asked me to modify my action call based on your review. However, the on_action is coming from the mock server, so I can't make any changes to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TRV-10 Ride Hailing Services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants