Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValidusFintechServices FIS14 + IGM logs #1891

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

ravindra-aditya
Copy link

@ravindra-aditya ravindra-aditya commented Jan 12, 2025

Validus Fintech Services - FIS14 + IGM pre-prod logs for review.

Included Flow Logs:

  1. Search - Full Pull
  2. Search - Register & Incremental Pull
  3. Search - Incremental Pull
  4. Lumpsum new folio w/ kyc
  5. Lumpsum new folio w/o kyc
  6. Lumpsum existing folio
  7. SIP new folio w/ kyc
  8. SIP new folio w/o kyc
  9. SIP existing folio
  10. SIP manual cancel
  11. Redemption
  12. IGM

Note: we are aligned with Pramaan integration test suite.

@92shreyansh 92shreyansh added IGM Issue & Grievence Management FIS-14 Investments labels Jan 14, 2025
@sourabhsaini11
Copy link

@ravindra-aditya
Please resubmit the flows on the basis of what is defined at log-submission ui. Additionally Instead of a single file for a flow, segregate the files further on the basis of action on_action calls.

@sourabhsaini11
Copy link

@ravindra-aditya Please resubmit the flows on the basis of what is defined at log-submission ui. Additionally Instead of a single file for a flow, segregate the files further on the basis of action on_action calls.

@ravindra-aditya

@ravindra-aditya
Copy link
Author

@ravindra-aditya Please resubmit the flows on the basis of what is defined at log-submission ui. Additionally Instead of a single file for a flow, segregate the files further on the basis of action on_action calls.

@ravindra-aditya

@sourabhsaini11 over to you for review. please share feedback at earliest.

@sourabhsaini11
Copy link

@ravindra-aditya,
on_search

  • BAP_TERMS are not required

common_issue

  • code APPLICATION_FORM should be present instead of APPLICATION_FORM_WITH_KYC at CHECKLISTS

select

  • items.fulfillment_ids is not required

on_select

  • timestamp can't be same as select's timestamp
  • missing IDCW_OPTION at PLAN_OPTIONS tag-group
  • additional element payments[1] present(/on_select_4 only)

on_status

  • timestamp can't be same as past call's timestamp
  • created_at & updated_at can't be greater than context.timestamp
  • missing IDCW_OPTION at PLAN_OPTIONS tag-group

on_init

  • timestamp can't be same as init's timestamp
  • missing IDCW_OPTION at PLAN_OPTIONS tag-group

on_confirm

  • timestamp can't be same as confirm's timestamp
  • created_at should be same as past call's created_at
  • updated_at can't be greater than context.timestamp
  • missing params.transaction_id
  • missing IDCW_OPTION at PLAN_OPTIONS tag-group
  • fulfillments[1].state should be PENDING

on_status

  • created_at should be same as past call's created_at
  • updated_at can't be greater than context.timestamp
  • missing IDCW_OPTION at PLAN_OPTIONS tag-group

on_update

  • missing FOLIO_INFORMATION
  • additional attribute ref_order_ids
  • invalid parent_item_id
  • id's are changed b/w on_status & on_update
  • created_at should be same as past call's created_at
  • updated_at can't be greater than context.timestamp
  • missing IDCW_OPTION at PLAN_OPTIONS tag-group

Flow-4
common_issues

  • missing IDCW_OPTION at PLAN_OPTIONS tag-group

9_on_update_1

  • message_id can't be same as past call's message_id

10_on_status_1

  • timestamp can't be same as on_confirm's timestamp

on_select

  • missing FOLIO_INFORMATION
  • tag-group CHECKLISTS is not required
  • payment array is incorrect

on_init

  • multiple OFFLINE_CONTRACT tags present
  • tag-group CHECKLISTS is not required
  • created_at & updated_at can't be greater than timestamp

confirm

  • multiple OFFLINE_CONTRACT tags present

on_confirm

  • created_at should be same as past call's created_at
  • updated_at can't be greater than context.timestamp
  • multiple OFFLINE_CONTRACT tags present
  • tag-group CHECKLISTS is not required

on_status, on_update

  • created_at should be same as past call's created_at
  • updated_at can't be greater than context.timestamp
  • tag-group CHECKLISTS is not required

on_cancel

  • cancellation.time, created_at & updated_at can't be greater than context.timestamp
  • type FOLIO at items in not required
  • missing value for APPLICATION_FORM
  • multiple BAP_TERMS, BPP_TERMS, CONSUMER_INFO present

Lumpsum - New Folio
on_select_2

  • items[0].tags[3].list[2].descriptor KYC and ESIGN missing in the payload.

@sourabhsaini11
Copy link

@ravindra-aditya, logs from staging env aren't meant for log-verification purpose. Going Forward the same won't be considered. Kindly update the logs to correct env(pre-prod) with fixes.

@amitsinha07
Copy link

@ravindra-aditya

Issue

TTL: Should be PT30S as per the API Contract.

On_issue

TTL: Should be PT30S as per the API Contract.
created_at: Should match the issue's created_at.

Issue_status

TTL: Should be PT30S as per the API Contract.

On_issue_status

Context/message_id: Mismatched with the context/message_id of the issue_status call.
TTL: Should be PT30S as per the API Contract.
created_at: Should match the issue's created_at.

Respondent Actions

message/issue/issue_actions/respondent_actions/0/respondent_action: Should be "Processing".
message/issue/issue_actions/respondent_actions/1/respondent_action: Should be "Resolved".

@ravindra-aditya
Copy link
Author

@sourabhsaini11 @amitsinha07 @92shreyansh @Sujit-SahaV We started working on fixing the defects and will push update once we have our pre-prod readiness is met. Tentatively this might take ~ 1 week from now. Thankyou.

1) Search (Full Pull)
2) Search And Register for incremental pull
3) Search incremental pull
1) Redemption
2) SIP Creation (New Folio)
3) SIP Creation (Existing Folio - Investor selects/enters a folio)
4) SIP cancellation by the investor
5) Lumpsum - New Folio
6) Lumpsum Investment (Existing Folio - Investor selects/enters a folio)
@ravindra-aditya
Copy link
Author

@sourabhsaini11 @amitsinha07 @92shreyansh -
pre-prod logs are now available for review. please, let us know if you have any questions. thankyou.

cc' @Sujit-SahaV

@ravindra-aditya
Copy link
Author

@sourabhsaini11 @amitsinha07 @92shreyansh - pre-prod logs are now available for review. please, let us know if you have any questions. thankyou.

cc' @Sujit-SahaV

@sourabhsaini11 @amitsinha07 any suggestions here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FIS-14 Investments IGM Issue & Grievence Management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants