Redbus Intracity-bus logs

[swasthikshetty10]

No description provided.

[gitguardian]

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
-	-	Generic High Entropy Secret	8da76bc	TRV11/redbus/Intracity-bus/on_update.json	View secret
-	-	Generic High Entropy Secret	b6afe37	TRV11/redbus/Intracity-bus/on_confirm.json	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secrets safely. Learn here the best practices.
3. Revoke and rotate these secrets.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

[sourabhsaini11]

@swasthikshetty10
common_issues

• empty billing attributes should not be present
• remove empty attributes present
• search_1-on_search_1 pair api calls & cancellation flows are missing
• for SETTLEMENT_WINDOW, correct format/value should be P1D
• How come for each action call, milliseconds from timestamp is same

search

• collected_by can't be empty

on_select

• message_id mismatch with select's message_id
• missing fulfillment having type as TICKET

init

• params can't be part at /init if collector is BAP
• invalid SETTLEMENT_DETAILS tag-group found
• SETTLEMENT_TERMS tag-group is empty

on_init

• missing fulfillment having type as TICKET
• invalid SETTLEMENT_DETAILS tag-group found
• SETTLEMENT_TERMS tag-group is empty

on_confirm

• empty billing attributes shouldn't be present
• created_at & updated_at should match with timestamp
• fulfillment F31 should also be part of items.fulfillment_ids

update

• How can BAP update vehicle info

on_update

• attribute stops.authorization shouldn't be present for fulfillment with type TRIP
• updated_at shouldn't be same as past call's updated_at
• fulfillment F31 should also be part of items.fulfillment_ids

[swasthikshetty10]

@sourabhsaini11

All mentioned issues are resolved and updated in this pr. On-call issues need to be handled by the seller. The updated flow allows users to update the bus registration number upon onboarding.

[sourabhsaini11]

@swasthikshetty10
common_issues

• for SETTLEMENT_WINDOW, correct format/value should be P1D

search2

• timestamp should be greater than past call's timestamp

init

• quantity.count is changed b/w select & init
• params shouldn't be present if collector is BPP for init

on_select

• missing fulfillment having type as TICKET

on_init

• item.price & quote are changed b/w on_select & on_init
• missing fulfillment having type as TICKET

confirm

• billing.phone, SETTLEMENT_TYPE, SETTLEMENT_AMOUNT & items.id are changed b/w init & confirm

on_confirm
-remove empty descriptor.name

update

• How can BAP update vehicle info

on_update

• created_at & updated_at can't be greater than timestamp
• invalid attribute stops.authorization at fulfillment.type TRIP

[swasthikshetty10]

@sourabhsaini11
fixed all issues at buyer side.
For BAP updating vehicle info, its vehicle based confirmation flow as per ONDC mobility docs.

[sourabhsaini11]

@swasthikshetty10, kindly provide flow for cancellation as well