Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dmrc metro preprod log #1914

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

VimalPelocal
Copy link

PeLocal: Dmrc metro preprod log

Copy link

gitguardian bot commented Jan 28, 2025

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - Generic High Entropy Secret 177dafc TRV11/PeLocal/on_confirm.json View secret
- - Generic High Entropy Secret cee5e4f TRV11/PeLocal/on_confirm.json View secret
- - Generic High Entropy Secret 3a58df9 TRV11/PeLocal/on_confirm.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@92shreyansh 92shreyansh added the TRV-11 Unreserved-Ticket label Jan 31, 2025
@sourabhsaini11
Copy link

@VimalPelocal
common_issues

  • How can billing.phone be same as the one provided in api-contract
  • tag SETTLEMENT_AMOUNT value can't be 0.

on_search

  • misisng ROUTE_INFO tag-group

on_init

  • missing fulfillment obj having type "TICKET"

on_confirm

  • tags SETTLEMENT_BASIS & SETTLEMENT_WINDOW values are changed b/w on_init & on_confirm
  • missing fulfillment obj having type "TICKET"

on_status

  • created_at value should be same as past call's created_at
  • missing fulfillment obj having type "TICKET"
  • invalid status EXPIRED, should be one of enums defined in api-contract

Note: please provide cancel, IGM & RSF flows also.

@VimalPelocal
Copy link
Author

@sourabhsaini11 , The verification logs are updated as per instructions,

common_issues
• How can billing.phone be same as the one provided in api-contract --> Done
• tag SETTLEMENT_AMOUNT value can't be 0. --> Done

on_search
◇ misisng ROUTE_INFO tag-group --> Seller Side

on_init
◇ missing fulfillment obj having type "TICKET" --> Seller Side

on_confirm
◇ tags SETTLEMENT_BASIS & SETTLEMENT_WINDOW values are changed b/w on_init & on_confirm --> Seller Side
◇ missing fulfillment obj having type "TICKET" --> Seller Side

on_status
◇ created_at value should be same as past call's created_at --> Seller Side
◇ missing fulfillment obj having type "TICKET" --> Seller Side
◇ invalid status EXPIRED, should be one of enums defined in api-contract --> Seller Side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TRV-11 Unreserved-Ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants