#886 implement pandas v2.1.0 #905
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to standardise the way in which observation status columns are handled, for a standard shape cube, if an attribute column is an SDMXA obs status column, the attribute's
observation_value_col_titlenow defaults to the cube's obs val column.This has been added to the validate_observations function in utils/qb/validation/observations.py - I would have preferred to add it to readers/cubeconfig/v1/configdeserialiser.py, but at this point columns don't have any knowledge of each other, which is required in order to associate the attribute column with the obs val column.