Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved description into dl tag in message list component #3465

Merged
merged 15 commits into from
Jan 22, 2025

Conversation

SriHV
Copy link
Contributor

@SriHV SriHV commented Dec 24, 2024

What is the context of this PR?

204

Moved description into dl tag in message list component.

To achieve this new param bodyLabel was added and ariaLabelMsg param was deprecated.

As per the deprecation implementation process available in confluence
(DEPRECATED) is added to the ariaLabelMsg param and NEW is added to the bodyLabel param in message list documentation.

How to review this PR

Inspect example-message-list.html in send and reply message patterns and check that the description is inside the dl tag.

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

Copy link

netlify bot commented Dec 24, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit e899b99
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/678e38769cc5330008e35912
😎 Deploy Preview https://deploy-preview-3465--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SriHV SriHV self-assigned this Dec 24, 2024
@SriHV SriHV added the Bug Something isn't working label Dec 24, 2024
@SriHV SriHV marked this pull request as ready for review December 24, 2024 17:24
src/components/message-list/_macro.njk Outdated Show resolved Hide resolved
src/components/message-list/_macro.njk Outdated Show resolved Hide resolved
src/components/message-list/_macro.njk Outdated Show resolved Hide resolved
src/components/message-list/_macro.spec.js Show resolved Hide resolved
@rmccar
Copy link
Contributor

rmccar commented Jan 10, 2025

As this is a deprecation we need to follow the process outlined in the "Deprecation Implementation and Release Process" in confluence we have set out. You have added the "(DEPRECATED)" tag but we need to follow the other parts of the process

@SriHV
Copy link
Contributor Author

SriHV commented Jan 10, 2025

As this is a deprecation we need to follow the process outlined in the "Deprecation Implementation and Release Process" in confluence we have set out. You have added the "(DEPRECATED)" tag but we need to follow the other parts of the process

I had doubt on this one. I will add the rest now now

src/components/message-list/_macro.spec.js Show resolved Hide resolved
src/components/message-list/_macro.spec.js Outdated Show resolved Hide resolved
@SriHV SriHV merged commit 490aa26 into main Jan 22, 2025
28 checks passed
@SriHV SriHV deleted the fix/3427/move-message-body-into-dl branch January 22, 2025 11:56
@rmccar rmccar added Accessibility Issues discovered through accessibility testing and removed Bug Something isn't working labels Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Issues discovered through accessibility testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants