-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved description into dl tag in message list component #3465
Conversation
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
As this is a deprecation we need to follow the process outlined in the "Deprecation Implementation and Release Process" in confluence we have set out. You have added the "(DEPRECATED)" tag but we need to follow the other parts of the process |
I had doubt on this one. I will add the rest now now |
…om/ONSdigital/design-system into fix/3427/move-message-body-into-dl
What is the context of this PR?
204
Moved description into dl tag in message list component.
To achieve this new param
bodyLabel
was added andariaLabelMsg
param was deprecated.As per the deprecation implementation process available in confluence
(DEPRECATED)
is added to theariaLabelMsg
param andNEW
is added to thebodyLabel
param in message list documentation.How to review this PR
Inspect example-message-list.html in send and reply message patterns and check that the description is inside the dl tag.
Checklist
This needs to be completed by the person raising the PR.