Conversation
…n system video embed template
ec7e833 to
f325aa1
Compare
zerolab
reviewed
Jan 6, 2025
Contributor
zerolab
left a comment
There was a problem hiding this comment.
Added a couple of quick thoughts
b162bf1 to
d45b7ba
Compare
nehakerung
reviewed
Jan 7, 2025
Contributor
nehakerung
left a comment
There was a problem hiding this comment.
LGTM - just did a functional tests and all works as mentioned 🎉
Adding a preview image might be tedious, but since it's DS compliant, I'll ignore it.🫡
d45b7ba to
70887da
Compare
f8a7305 to
c4dc506
Compare
Contributor
Author
Thanks @nehakerung! |
zerolab
reviewed
Jan 8, 2025
zerolab
reviewed
Jan 8, 2025
helenb
commented
Jan 9, 2025
zerolab
requested changes
Jan 13, 2025
zerolab
approved these changes
Jan 14, 2025
…ake the template vars more consistent
AdamHawtin
approved these changes
Jan 15, 2025
Contributor
AdamHawtin
left a comment
There was a problem hiding this comment.
Looks good to me, just a suggestion for the unit tests.
sanjeevz3009
approved these changes
Jan 15, 2025
Contributor
sanjeevz3009
left a comment
There was a problem hiding this comment.
LGTM =) Tested everything and exhausted all the blocks on the info page and everything is working as it should.
ababic
pushed a commit
that referenced
this pull request
Jan 16, 2025
* main: Update the embed block to be a custom video embed that uses the design system video embed template (#62) Django Migration Linter Integration (#43) Tidy up the info/warning panel and fix title/no title output (#73) Introduce Functional Tests using Playwright and Behave #31 # Conflicts: # poetry.lock # pyproject.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
See https://jira.ons.gov.uk/browse/CMS-204
How to review
Screenshots
Click to expand
With cookies accepted
Without cookies accepted
Follow-up Actions