-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the embed block to be a custom video embed that uses the design system video embed template #62
Conversation
…n system video embed template
ec7e833
to
f325aa1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple of quick thoughts
b162bf1
to
d45b7ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just did a functional tests and all works as mentioned 🎉
Adding a preview image might be tedious, but since it's DS compliant, I'll ignore it.🫡
d45b7ba
to
70887da
Compare
f8a7305
to
c4dc506
Compare
Thanks @nehakerung! |
…ake the template vars more consistent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just a suggestion for the unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM =) Tested everything and exhausted all the blocks on the info page and everything is working as it should.
* main: Update the embed block to be a custom video embed that uses the design system video embed template (#62) Django Migration Linter Integration (#43) Tidy up the info/warning panel and fix title/no title output (#73) Introduce Functional Tests using Playwright and Behave #31 # Conflicts: # poetry.lock # pyproject.toml
What is the context of this PR?
See https://jira.ons.gov.uk/browse/CMS-204
How to review
Screenshots
Click to expand
With cookies accepted
Without cookies accepted
Follow-up Actions