Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utl::vector refactoring without inheritance of std::vector #729

Merged
merged 11 commits into from
Feb 7, 2025

Conversation

kmokstad
Copy link
Contributor

@kmokstad kmokstad commented Jan 22, 2025

Changing the std::vector relationship from "is-a" to "has-a" since std::vector is not supposed to be inherited. A bit more changes than initially planned, but this is basically what it takes. The commits are quite fragmented to better see how things are related. The first 9 commits are actually independent of the utl::vector refactor in the 10th commit and could be implemented first without changing the vector class. But they are necessary to make things work after the changes in commit 10. The last commit is side effects of the changes made in commit 10, but is kept separately for clarity.

Quite some downstream affections of course, which will be added subsequently.

@kmokstad
Copy link
Contributor Author

jenkins build this with downstreams ifem-poisson=61 ifem-darcy=68 ifem-elasticity=173 ifem-poroelasticity=68 ifem-openfrac=83 ifem-stokes=310 ifem-navierstokes=253 ifem-boussinesq=144 ifem-fsi=82 simra-postproc=17 please

@kmokstad
Copy link
Contributor Author

jenkins build this with downstreams ifem-poisson=61 ifem-darcy=68 ifem-elasticity=173 ifem-poroelasticity=64 ifem-openfrac=83 ifem-stokes=310 ifem-navierstokes=253 ifem-boussinesq=144 ifem-fsi=82 simra-postproc=17 please

@kmokstad
Copy link
Contributor Author

jenkins build this with downstreams ifem-darcy=68 ifem-elasticity=173 ifem-poroelasticity=64 ifem-openfrac=83 ifem-stokes=310 ifem-navierstokes=253 ifem-boussinesq=144 ifem-fsi=82 simra-postproc=17 please

@kmokstad
Copy link
Contributor Author

jenkins build this with downstreams ifem-darcy=68 ifem-elasticity=173 ifem-poroelasticity=64 ifem-openfrac=83 ifem-stokes=310 ifem-navierstokes=253 ifem-boussinesq=144 ifem-fsi=82 simra-postproc=17 please

@kmokstad
Copy link
Contributor Author

kmokstad commented Feb 4, 2025

jenkins build this with downstreams ifem-elasticity=173 ifem-poroelasticity=64 ifem-openfrac=83 ifem-stokes=310 ifem-navierstokes=253 ifem-boussinesq=144 ifem-finitedeformation=45 simra-postproc=17 please

@kmokstad
Copy link
Contributor Author

kmokstad commented Feb 5, 2025

jenkins build this with downstreams ifem-elasticity=173 ifem-poroelasticity=64 ifem-openfrac=83 ifem-stokes=310 ifem-navierstokes=253 ifem-boussinesq=144 ifem-finitedeformation=45 simra-postproc=17 please

@kmokstad
Copy link
Contributor Author

kmokstad commented Feb 7, 2025

jenkins build this with downstreams ifem-elasticity=173 ifem-navierstokes=253 ifem-boussinesq=144 please

@kmokstad kmokstad merged commit 296d26b into OPM:master Feb 7, 2025
1 check passed
@kmokstad kmokstad deleted the vector-has-a branch February 7, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant