-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
utl::vector refactoring without inheritance of std::vector #729
Conversation
fa566de
to
8bd191b
Compare
jenkins build this with downstreams ifem-poisson=61 ifem-darcy=68 ifem-elasticity=173 ifem-poroelasticity=68 ifem-openfrac=83 ifem-stokes=310 ifem-navierstokes=253 ifem-boussinesq=144 ifem-fsi=82 simra-postproc=17 please |
jenkins build this with downstreams ifem-poisson=61 ifem-darcy=68 ifem-elasticity=173 ifem-poroelasticity=64 ifem-openfrac=83 ifem-stokes=310 ifem-navierstokes=253 ifem-boussinesq=144 ifem-fsi=82 simra-postproc=17 please |
8bd191b
to
7efa2e5
Compare
jenkins build this with downstreams ifem-darcy=68 ifem-elasticity=173 ifem-poroelasticity=64 ifem-openfrac=83 ifem-stokes=310 ifem-navierstokes=253 ifem-boussinesq=144 ifem-fsi=82 simra-postproc=17 please |
7efa2e5
to
a2819d4
Compare
jenkins build this with downstreams ifem-darcy=68 ifem-elasticity=173 ifem-poroelasticity=64 ifem-openfrac=83 ifem-stokes=310 ifem-navierstokes=253 ifem-boussinesq=144 ifem-fsi=82 simra-postproc=17 please |
a2819d4
to
ffd9c44
Compare
jenkins build this with downstreams ifem-elasticity=173 ifem-poroelasticity=64 ifem-openfrac=83 ifem-stokes=310 ifem-navierstokes=253 ifem-boussinesq=144 ifem-finitedeformation=45 simra-postproc=17 please |
ffd9c44
to
bff4035
Compare
jenkins build this with downstreams ifem-elasticity=173 ifem-poroelasticity=64 ifem-openfrac=83 ifem-stokes=310 ifem-navierstokes=253 ifem-boussinesq=144 ifem-finitedeformation=45 simra-postproc=17 please |
increasing the size for each basis
…ve a std::vector as member, with associated access methods like it was a std::vector object
bff4035
to
296d26b
Compare
jenkins build this with downstreams ifem-elasticity=173 ifem-navierstokes=253 ifem-boussinesq=144 please |
Changing the
std::vector
relationship from "is-a" to "has-a" sincestd::vector
is not supposed to be inherited. A bit more changes than initially planned, but this is basically what it takes. The commits are quite fragmented to better see how things are related. The first 9 commits are actually independent of theutl::vector
refactor in the 10th commit and could be implemented first without changing the vector class. But they are necessary to make things work after the changes in commit 10. The last commit is side effects of the changes made in commit 10, but is kept separately for clarity.Quite some downstream affections of course, which will be added subsequently.