Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output More Restart File Items #4439

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Output More Restart File Items #4439

wants to merge 1 commit into from

Conversation

bska
Copy link
Member

@bska bska commented Jan 21, 2025

Needed for compatibility.

@bska
Copy link
Member Author

bska commented Jan 21, 2025

Note that despite the somewhat modest size of this PR in terms of number of changed lines, the actual impact is significant. Due to changing the number of items per well (XWEL array), connection (ICON and SCON arrays) or segment (RSEG array), as well as the contents of the INTEHEAD array, this PR breaks more or less every existing regression test. We will need to run a number of tests before we consider merging this. Thanks to @akva2's PR OPM/opm-simulators#5897, however, we have the ability to check that actual simulation results are not impacted by this change–only their on-disk representation in the restart file.

@bska
Copy link
Member Author

bska commented Jan 21, 2025

jenkins build this only_summary please

@bska bska force-pushed the rst-level-224 branch 12 times, most recently from d66c752 to 89e8ffe Compare January 28, 2025 13:42
@bska bska force-pushed the rst-level-224 branch 3 times, most recently from 27233aa to 7a120e7 Compare January 31, 2025 08:09
@bska
Output More Restart File Items
69123d4 
Needed for compatibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bska