Canonicalise Region Selectors in Action Conditions #4449
Conversation
|
I am creating this PR in draft mode for two reasons
I will keep the PR in a draft state until such time as it is ready for review and merging. The PR does however allow me to run --- /home/bska/work/opm/src/opm/opm-tests/udq_actionx/UDQ_REG-01.DATA 2024-02-08 10:44:34.853937886 +0100
+++ ./TEST1_FLOW.DATA 2024-06-02 14:20:04.000000000 +0200
@@ -252,6 +252,9 @@
RPR
1 2 3 4 5 6 /
+RPR__RE3
+/
+
FURE2
FUGASX
FUGIRD
@@ -261,8 +264,13 @@
SCHEDULE
------------------------------------------------------------------------------------------------
--- start: 10 'OCT' 2018 /
+-- __ start: 10 'OCT' 2018 /
+TUNING
+ 1.0 3.0 /
+ /
+ /
+
GRUPTREE
'TEST' 'FIELD' /
/
@@ -322,6 +330,17 @@
UNITS FUGIRDX SM3D /
/
+ACTIONX
+TESTR1 1000 10.0 /
+RPR 1 RE3 < 215.0 /
+/
+
+WELTARG
+ 'D-1H' 'ORAT' 1000.0 /
+/
+
+ENDACTIO
+
DATES
1 NOV 2018 /Here are some selected summary vectors from this run (
|
|
jenkins build this please |
bska
force-pushed
the
actionx-reg-select-syntax
branch
5 times, most recently
from
ab65298 to
67938b3
Compare
|
Perfect, this has now been tested in Equinor and results are excellent. Looking forward to see this going into master |
This commit translates ACTIONX condition region quantities of the
form
RPR 1 RE3
i.e., including the region set name 'RE3' (FIPRE3) into the common
summary vector format
RPR__RE3 1
which is expected elsewhere. Doing so enables using the former
syntax in ACTIONX conditions like
RPR 1 RE3 < 215 /
without incurring significant downstream changes in the vector
evaluation code. Defaulted ('1*') or blank (' ') region set names
are treated as the default region set (FIPNUM).
bska
force-pushed
the
actionx-reg-select-syntax
branch
from
67938b3 to
3053b04
Compare
Thank you for testing. In that case I'll mark this PR as "ready for review" and I'll run a build check. |
|
jenkins build this please |
|
PR approved and build check is green. I'll merge into master. |
|
Wow, nice clean diff for such an improvement. 💪 |
Thanks! Sometimes the stars just align to enable these kinds of changes. |
This PR translates
ACTIONXcondition region quantities of the formi.e., including the region set name
RE3(FIPRE3) into the common summary vector formatwhich is expected elsewhere. Doing so enables using the former syntax in
ACTIONXconditions likewithout incurring significant downstream changes in the vector evaluation code. Defaulted (
'1*') or blank (' ') region set names are treated as the default region set (FIPNUM).