Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare OPM for DUNE 2.10 #758

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prepare OPM for DUNE 2.10 #758

wants to merge 1 commit into from

Conversation

blattms
Copy link
Member

@blattms blattms commented Sep 7, 2024

DUNE_VERSION_NEWER has been removed. Falling back to DUNE_VERSION_GTE which exists since at least DUNE 2.7

Use Dune::Communcation instead of removed Dune::CollectiveCommunication (there since at least DUNE 2.7)l

@blattms
Copy link
Member Author

blattms commented Sep 7, 2024

jenkins build this please

@blattms blattms marked this pull request as draft September 9, 2024 12:20
@blattms
Copy link
Member Author

blattms commented Sep 9, 2024

Making this draft until i have a compiling version

DUNE_VERSION_NEWER has been removed. Falling back to DUNE_VERSION_GTE
which exists since at least DUNE 2.7

Use Dune::Communcation instead of removed
Dune::CollectiveCommunication (there since at least DUNE 2.7)l
@blattms blattms marked this pull request as ready for review October 3, 2024 10:04
@blattms blattms added this to the Release 2024.10 milestone Oct 3, 2024
@timokoch
Copy link

timokoch commented Nov 6, 2024

@blattms This has not made it into the 2024.10 release? So currently there is no version compatible with dune 2.10 right? Or can this is be backported?

@bska
Copy link
Member

bska commented Nov 6, 2024

So currently there is no version compatible with dune 2.10 right?

Correct.

Or can this is be backported?

In my capacity as the release manager for the 2024.10 OPM release: It cannot as that would trigger a huge round of testing of the release packages. Dune 2.10 did not exist when we created the release branches for OPM 2024.10. Besides, the proper solution to the problem is arguably #745 (ping @akva2) and the other PRs listed in OPM/opm-common#4157.

On another note, I'm personally rather hesitant to declare "support" for Dune 2.10 since the OPM project has a stated policy of supporting the two most recent Ubuntu LTS releases (22.04 and 24.04 at the time of writing) and Dune 2.10 does not exist on either of those. In a sense OPM does not "need" Dune 2.10 until our 2026.04 release, although experience suggests we bring in some support for newer Dune releases earlier than that. It's a double-edged sword, though, because such support should really be backed by build testing as well which has a non-zero cost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants