-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On loadBalance(...) "addCornerCells" should be called "addEdgeCells"? #806
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th fully interior parent
…R1 with NNCs, LGR2 without
jenkins build this serial please |
aritorto
changed the title
Function argument on loadBalance(...) "addCornerCells" should be called "addEdgeCells"
Function argument on loadBalance(...) "addCornerCells" should be called "addEdgeCells"?
Nov 27, 2024
aritorto
changed the title
Function argument on loadBalance(...) "addCornerCells" should be called "addEdgeCells"?
On loadBalance(...) "addCornerCells" should be called "addEdgeCells"?
Nov 27, 2024
This was referenced Nov 27, 2024
REplaced by #808 (too many merge conflicts here) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to assign unique point ids on a distributed grid with LGRs, I invoked loadBalance, enabling the inclusion of cells that share corners with interior cells on each process by setting addCornerCells = true (one of the function arguments in loadBalance). However, instead of adding corner-sharing cells, this configuration primarily adds cells that share edges, in addition to the overlap layer of size 1. As a result, cells that share only a corner are not included, which can impact the uniqueness of point ids in certain cases.
In the test addLgrsOnDistributedGrid_test.cpp, both escenarios are included:
Based on #802.
Not relevant for the Reference Manual.