Add Support for Edge Conformal Corner-Point Grid Processing #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this please |
bska
force-pushed
the
edge-conformal-grid-processing
branch
2 times, most recently
from
a90f24c to
52e13da
Compare
bska
force-pushed
the
edge-conformal-grid-processing
branch
2 times, most recently
from
b2c5191 to
f61a79f
Compare
bska
force-pushed
the
edge-conformal-grid-processing
branch
3 times, most recently
from
93b9d97 to
06a92df
Compare
bska
force-pushed
the
edge-conformal-grid-processing
branch
3 times, most recently
from
3e04a44 to
3b9e712
Compare
bska
force-pushed
the
edge-conformal-grid-processing
branch
5 times, most recently
from
ba9a00c to
6e48eb1
Compare
|
jenkins build this opm-simulators=5806 please |
|
Just to be very clear: The new |
|
jenkins build this opm-simulators=5806 opm-upscaling=397 please |
bska
force-pushed
the
edge-conformal-grid-processing
branch
from
6e48eb1 to
0cd0cd2
Compare
|
jenkins build this opm-simulators=5806 opm-upscaling=397 please |
bska
force-pushed
the
edge-conformal-grid-processing
branch
from
0cd0cd2 to
4fc5edd
Compare
|
jenkins build this opm-simulators=5806 opm-upscaling=397 please |
bska
force-pushed
the
edge-conformal-grid-processing
branch
from
4fc5edd to
191c5f4
Compare
|
jenkins build this opm-simulators=5806 opm-upscaling=397 please |
bska
force-pushed
the
edge-conformal-grid-processing
branch
from
191c5f4 to
bc2d659
Compare
|
jenkins build this opm-simulators=5806 opm-upscaling=397 please |
bska
force-pushed
the
edge-conformal-grid-processing
branch
from
bc2d659 to
a7fe08b
Compare
|
jenkins build this opm-simulators=5806 opm-upscaling=397 please |
bska
force-pushed
the
edge-conformal-grid-processing
branch
from
a7fe08b to
2e4e079
Compare
|
jenkins build this opm-simulators=5806 opm-upscaling=397 please |
bska
force-pushed
the
edge-conformal-grid-processing
branch
from
2e4e079 to
c828f5f
Compare
|
jenkins build this opm-simulators=5806 opm-upscaling=397 please |
bska
force-pushed
the
edge-conformal-grid-processing
branch
from
c828f5f to
e556242
Compare
|
jenkins build this opm-simulators=5806 opm-upscaling=397 please |
bska
force-pushed
the
edge-conformal-grid-processing
branch
from
e556242 to
9065bdf
Compare
|
jenkins build this opm-simulators=5806 opm-upscaling=397 please |
Initially supported fully only for the 'UnstructuredGrid' (create_grid_cornerpoint() constructor, PolyhedralGrid wrapper), this commit introduces amended logic that aims to create edge conformal cell complexes. Specifically, the faces of the 'processed_grid' structure from 'process_grdecl()' contains *all* vertices along the pillars, not just the top and bottom vertices of the traditional corner-point description. Moreover, the create_grid_cornerpoint() will insert additional vertices in the top and bottom *faces* when the edge conformal mode is activated. This aspect is not yet available in the CpGrid wrapper, though the vertices along the pillars will be included in that case too. Client code may activate this mode by setting the 'edge_conformal' flag to 'true'. The flag is a bool (i.e., _Bool) in both the C and the C++ code, but transmitted as an 'int' across the language boundary. At this time, the mode is intended to support geo-mechanical workflows and should typically not be enabled in production runs of regular reservoir simulations. While here, split some long lines and mark objects 'const' where possible.
bska
force-pushed
the
edge-conformal-grid-processing
branch
from
9065bdf to
45d24f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially supported fully only for the
UnstructuredGrid(create_grid_cornerpoint()constructor,PolyhedralGridwrapper), this PR introduces amended logic that aims to create edge conformal cell complexes. Specifically, the faces of theprocessed_gridstructure fromprocess_grdecl()contains all vertices along the pillars, not just the top and bottom vertices of the traditional corner-point description. Moreover, thecreate_grid_cornerpoint()function will insert additional vertices in the top and bottom faces when the edge conformal mode is activated. This aspect is not yet available in theCpGridimplementation, though the vertices along the pillars will be included in that case too.Client code may activate this mode by setting the
edge_conformalflag totrue. The flag is abool(i.e.,_Bool) in both the C and the C++ code, but transmitted as anintacross the language boundary.At this time, the mode is intended to support geo-mechanical workflows and should typically not be enabled in production runs of regular reservoir simulations. Furthermore, this is not tested or supported in parallel runs.
While here, split some long lines and mark objects
constwhere possible.Work by @hnil.