In docs makefile: move declaration of CURRENT_PATH variable up, this …

[lisajulia]

…was causing an error for me before

[hakonhagland]

was causing an error for me before

@lisajulia What kind of error did you get?

[lisajulia]

was causing an error for me before

@lisajulia What kind of error did you get?

The variable was not set, i.e.:

opm-python-documentation/python/sphinx_docs$ make
sphinx-versioned -m $CURRENT_BRANCH -b $CURRENT_BRANCH --git-root ../../
| SUCCESS  | - latched into the git repo
| SUCCESS  | - located conf.py
| WARNING  | - git head detached: True
| INFO     | - pre-building: master
/home/lnebel/git_repos/opm-pyaction/opm-python-documentation/python/docstrings_common.json
/home/lnebel/git_repos/opm-pyaction/opm-python-documentation/python/docstrings_simulators.json
| SUCCESS  | - pre-build succeded for master :)
| SUCCESS  | - Prebuilding successful for master
| INFO     | - Building: master
| INFO     | - Theme: sphinx_rtd_theme
/home/lnebel/git_repos/opm-pyaction/opm-python-documentation/python/docstrings_common.json
/home/lnebel/git_repos/opm-pyaction/opm-python-documentation/python/docstrings_simulators.json
| SUCCESS  | - build succeded for master ;)
| CRITICAL | - main branch `-b` not found!! / not building `-b`; top-level `index.html` will not be generated!

 Successfully built master 

[hakonhagland]

Thanks! I think I see the problem now: each line in a Makefile recipe is executed in its own shell, so the second line in docs will not know about the variable set in the first line. Then, we could also fix this by converting the two lines into a single line like this:

   @CURRENT_BRANCH=$(shell git rev-parse --abbrev-ref HEAD) && \
    sphinx-versioned -m $$CURRENT_BRANCH -b $$CURRENT_BRANCH --git-root ../../

Or make CURRENT_BRANCH a global variable as proposed in this PR.