Skip to content

Mark ROCKTAB as supported#220

Closed
gdfldm wants to merge 2 commits intoOPM:mainfrom
gdfldm:rocktab-supported
Closed

Mark ROCKTAB as supported#220
gdfldm wants to merge 2 commits intoOPM:mainfrom
gdfldm:rocktab-supported

Conversation

@gdfldm
Copy link
Copy Markdown
Collaborator

@gdfldm gdfldm commented Apr 4, 2024

in keyword description and appendix a
Addresses #219

gdfldm added 2 commits April 4, 2024 12:20
Minor updates to text
TODO update Appendix A
@blattms
Copy link
Copy Markdown
Member

blattms commented Apr 12, 2024

The diff of A.fdot is rather large...

@gdfldm , who did you perform these changes? With scripts?

@hakonhagland, might the add_keyword_status.py mess up the diff due changing xml-end-tags?

@hakonhagland
Copy link
Copy Markdown
Collaborator

might the add_keyword_status.py mess up the diff due changing xml-end-tags?

@blattms Yes you are right, it would. I think the end tags was fixed in #227 but that is not merged yet.

@gdfldm
Copy link
Copy Markdown
Collaborator Author

gdfldm commented Apr 17, 2024

who did you perform these changes? With scripts?

@blattms I used the script to update Appendix A. Then edited the XML for ROCKTAB.fodt.

@gdfldm
Copy link
Copy Markdown
Collaborator Author

gdfldm commented May 20, 2024

replaced by #237

@gdfldm gdfldm closed this May 20, 2024
@gdfldm gdfldm deleted the rocktab-supported branch May 23, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants