Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix add keyword #229

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Fix add keyword #229

merged 2 commits into from
Apr 16, 2024

Conversation

hakonhagland
Copy link
Collaborator

This PR builds on #212, which should be merged first.

For background see #228. Updated the add-keyword script to handle empty tags.

@blattms
Copy link
Member

blattms commented Apr 12, 2024

Does this also automatically apply to add_keyword_status.py?

@hakonhagland
Copy link
Collaborator Author

Does this also automatically apply to add_keyword_status.py?

@blattms No, but the set-keyword-status script was fixed to handle empty tags in #227 I believe

@lisajulia
Copy link
Collaborator

lisajulia commented Apr 16, 2024

@hakonhagland: I'll look at this next :) - can you rebase it? Thanks!

Fixed add-keyword script to handle empty tags
Updated add-keyword script to handle empty tags.
@hakonhagland
Copy link
Collaborator Author

@lisajulia Sure!

Copy link
Collaborator

@lisajulia lisajulia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; I've tested this as well.

@lisajulia lisajulia merged commit f84948f into OPM:main Apr 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants