Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in the run docker container script #255

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hakonhagland
Copy link
Collaborator

For background see #208 (comment).

The git root will not always be 3 levels up from the filename. Added a more advanced method to find the git root. Also added a test case.

@blattms
Copy link
Member

blattms commented Jun 5, 2024

With this, can I call the scripts anywhere?
I had the impression that there even have been assumptions where the venv directory was created. Seemed like it had to be created below scripts/python

While I would have created it directly in the root directory.

The git root will not always be 3 levels up from the filename. Added
a more advanced method to find the git root.
@hakonhagland
Copy link
Collaborator Author

hakonhagland commented Jun 5, 2024

Seemed like it had to be created below scripts/python

@blattms Yes, I tried now with "pip install ./docker" from the root directory, and there seems to be some assumptions in the script about the current directory being "<root>/docker" when running the docker python scripts. I will check what is going on.

Also try to located via CWD if __file__ fails
@hakonhagland
Copy link
Collaborator Author

@blattms I have updated the script such that the user can do "pip install ./docker" from the root directory of the git repository or from anywhere he likes (instead of first cwd to docker and then do "pip install ."). Can you retest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants