Add Bug Fixes to 2024-10 Release Note #438
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blattms
reviewed
Dec 20, 2024
| <text:p text:style-name="P1298">Directly output the SGMAX, SHMAX, SOMAX, SOMIN and SWHY1 arrays rather than the KRNSW_GO, KRNSW_OW, PCSWM_GO, PCSWM_OW and SOMAX arrays to the Restart file for cases with relative permeability and/or capillary pressure hysteresis (<text:a xlink:type="simple" xlink:href="https://github.com/OPM/opm-simulators/pull/5402" text:style-name="Internet_20_link" text:visited-style-name="Visited_20_Internet_20_Link">#5402</text:a>). </text:p> | ||
| </text:list-item> | ||
| <text:list-item> | ||
| <text:p text:style-name="P1298">Sphinx documentation has been added for the opm.simulators.BlackOilSimulator Python module (<text:a xlink:type="simple" xlink:href="https://github.com/OPM/opm-simulators/pull/5243" text:style-name="Internet_20_link" text:visited-style-name="Visited_20_Internet_20_Link">#5243</text:a>). </text:p> |
There was a problem hiding this comment.
Maybe a link to the documentation would be nice. https://opm.github.io/opm-python-documentation/master/index.html
| <text:p text:style-name="P1298">Consistency checks have been added for three-point saturation scaling SCALECRS=YES (<text:a xlink:type="simple" xlink:href="https://github.com/OPM/opm-simulators/pull/5573" text:style-name="Internet_20_link" text:visited-style-name="Visited_20_Internet_20_Link">#5573</text:a>,<text:a xlink:type="simple" xlink:href="https://github.com/OPM/opm-simulators/pull/5640" text:style-name="Internet_20_link" text:visited-style-name="Visited_20_Internet_20_Link">#5640</text:a>). These checks collectively guarantee a mobile displacing oil saturation in the two phase gas-oil and oil-water systems. </text:p> | ||
| </text:list-item> | ||
| <text:list-item> | ||
| <text:p text:style-name="P1298">Support has been added for Python >= 3.8, whilst support has been maintained for Python 3.6 and 3.7 (<text:a xlink:type="simple" xlink:href="https://github.com/OPM/opm-simulators/pull/5644" text:style-name="Internet_20_link" text:visited-style-name="Visited_20_Internet_20_Link">#5644</text:a>). </text:p> |
There was a problem hiding this comment.
maybe we need to rephrase this.
Said PR just changes the dependencies for the OPM pypi packages to support also newer versions. Version 3.6-3.12 seem supported
| <text:p text:style-name="P1298">It is no longer necessary to use add well contributions to matrix for NLDD. Also, the CPRW preconditioner is now supported for NLDD (<text:a xlink:type="simple" xlink:href="https://github.com/OPM/opm-simulators/pull/5341" text:style-name="Internet_20_link" text:visited-style-name="Visited_20_Internet_20_Link">#5341</text:a>,<text:a xlink:type="simple" xlink:href="https://github.com/OPM/opm-simulators/pull/5676" text:style-name="Internet_20_link" text:visited-style-name="Visited_20_Internet_20_Link">#5676</text:a>). </text:p> | ||
| </text:list-item> | ||
| <text:list-item> | ||
| <text:p text:style-name="P1298">The number of pinch-out connections generated will now be reported to the Print file (<text:a xlink:type="simple" xlink:href="https://github.com/OPM/opm-grid/pull/767" text:style-name="Internet_20_link" text:visited-style-name="Visited_20_Internet_20_Link">#767</text:a>). </text:p> |
| <text:p text:style-name="P1298">Avoid unnecessarily checking if the fluid is saturated in CO2STORE and H2STORE cases (<text:a xlink:type="simple" xlink:href="https://github.com/OPM/opm-common/pull/4125" text:style-name="Internet_20_link" text:visited-style-name="Visited_20_Internet_20_Link">#4125</text:a>). </text:p> | ||
| </text:list-item> | ||
| <text:list-item> | ||
| <text:p text:style-name="P1298">If the injection fluid temperature has not been set for an injection well then it now defaults to the cell temperature in the upper most completion (<text:a xlink:type="simple" xlink:href="https://github.com/OPM/opm-simulators/pull/5490" text:style-name="Internet_20_link" text:visited-style-name="Visited_20_Internet_20_Link">#5490</text:a>,<text:a xlink:type="simple" xlink:href="https://github.com/OPM/opm-common/pull/4155" text:style-name="Internet_20_link" text:visited-style-name="Visited_20_Internet_20_Link">#4155</text:a>,<text:a xlink:type="simple" xlink:href="https://github.com/OPM/opm-common/pull/4152" text:style-name="Internet_20_link" text:visited-style-name="Visited_20_Internet_20_Link">#4152</text:a>). </text:p> |
| <text:p text:style-name="P1298">Add support for converting between formatted (.FGRID) and unformatted (.GRID) grid files to the convertECL utility (<text:a xlink:type="simple" xlink:href="https://github.com/OPM/opm-common/pull/4208" text:style-name="Internet_20_link" text:visited-style-name="Visited_20_Internet_20_Link">#4208</text:a>). </text:p> | ||
| </text:list-item> | ||
| <text:list-item> | ||
| <text:p text:style-name="P1298">An error message will now be generated if an attempt is made to copy an undefined array (for example using the COPY keyword). Similarly, operations on an array (for example the ADD keyword) other than assignment (for example using the EQUALS keyword) will now generate an error message if the array being operated on has not been previously been defined in the input deck (<text:a xlink:type="simple" xlink:href="https://github.com/OPM/opm-common/pull/4109" text:style-name="Internet_20_link" text:visited-style-name="Visited_20_Internet_20_Link">#4109</text:a>,<text:a xlink:type="simple" xlink:href="https://github.com/OPM/opm-common/pull/4235" text:style-name="Internet_20_link" text:visited-style-name="Visited_20_Internet_20_Link">#4235</text:a>). However, operations are allowed on multiplier arrays (MULTX, MULTY, etc.) that have not been explicitly defined in the input deck but have a default value of one (<text:a xlink:type="simple" xlink:href="https://github.com/OPM/opm-common/pull/4235" text:style-name="Internet_20_link" text:visited-style-name="Visited_20_Internet_20_Link">#4235</text:a>). </text:p> |
| @@ -13581,10 +13854,229 @@ Updated with AFR/TSA Rev-D comments and new keywords.</dc:description><meta:init | |||
| <text:list-item> | |||
| <text:list> | |||
| <text:list-item text:start-value="1"> | |||
| <text:p text:style-name="P1298">Item1</text:p> | |||
| <text:p text:style-name="P1298">Avoid sending and receiving from the same Buffer (<text:a xlink:type="simple" xlink:href="https://github.com/OPM/opm-simulators/pull/5297" text:style-name="Internet_20_link" text:visited-style-name="Visited_20_Internet_20_Link">#5297</text:a>). </text:p> | |||
There was a problem hiding this comment.
... to fix errors with MPICH on Redhat.
| <text:p text:style-name="P1298">Corrected definitions of GMDS and GMGP summary vectors (<text:a xlink:type="simple" xlink:href="https://github.com/OPM/opm-simulators/pull/5292" text:style-name="Internet_20_link" text:visited-style-name="Visited_20_Internet_20_Link">#5292</text:a>). </text:p> | ||
| </text:list-item> | ||
| <text:list-item> | ||
| <text:p text:style-name="P1298">Fixed a typo that would cause problems when compiling using CUD-aware MPI (<text:a xlink:type="simple" xlink:href="https://github.com/OPM/opm-simulators/pull/5368" text:style-name="Internet_20_link" text:visited-style-name="Visited_20_Internet_20_Link">#5368</text:a>). </text:p> |
There was a problem hiding this comment.
Suggested change
| <text:p text:style-name="P1298">Fixed a typo that would cause problems when compiling using CUD-aware MPI (<text:a xlink:type="simple" xlink:href="https://github.com/OPM/opm-simulators/pull/5368" text:style-name="Internet_20_link" text:visited-style-name="Visited_20_Internet_20_Link">#5368</text:a>). </text:p> | |
| <text:p text:style-name="P1298">Fixed a typo that would cause problems when compiling using CUDA-aware MPI (<text:a xlink:type="simple" xlink:href="https://github.com/OPM/opm-simulators/pull/5368" text:style-name="Internet_20_link" text:visited-style-name="Visited_20_Internet_20_Link">#5368</text:a>). </text:p> |
| <text:p text:style-name="P1298">Avoid mass creation when using DRSDT or DRSDTCON if hysteresis was deactivated (<text:a xlink:type="simple" xlink:href="https://github.com/OPM/opm-simulators/pull/5407" text:style-name="Internet_20_link" text:visited-style-name="Visited_20_Internet_20_Link">#5407</text:a>). </text:p> | ||
| </text:list-item> | ||
| <text:list-item> | ||
| <text:p text:style-name="P1298">If convergence failures due to NaN then report this a problem rather than an error, then chop the time step and continue (<text:a xlink:type="simple" xlink:href="https://github.com/OPM/opm-simulators/pull/5434" text:style-name="Internet_20_link" text:visited-style-name="Visited_20_Internet_20_Link">#5434</text:a>). </text:p> |
There was a problem hiding this comment.
Suggested change
| <text:p text:style-name="P1298">If convergence failures due to NaN then report this a problem rather than an error, then chop the time step and continue (<text:a xlink:type="simple" xlink:href="https://github.com/OPM/opm-simulators/pull/5434" text:style-name="Internet_20_link" text:visited-style-name="Visited_20_Internet_20_Link">#5434</text:a>). </text:p> | |
| <text:p text:style-name="P1298">If convergence failures due to NaN then report this as a problem rather than an error, then chop the time step and continue (<text:a xlink:type="simple" xlink:href="https://github.com/OPM/opm-simulators/pull/5434" text:style-name="Internet_20_link" text:visited-style-name="Visited_20_Internet_20_Link">#5434</text:a>). </text:p> |
| <text:p text:style-name="P1298">SFC (Space-Filling Curve) reordering for cells in AluGrid is now the default choice to optimise data access patterns for adaptive mesh refinements/coarsening (<text:a xlink:type="simple" xlink:href="https://github.com/OPM/opm-simulators/pull/5630" text:style-name="Internet_20_link" text:visited-style-name="Visited_20_Internet_20_Link">#5630</text:a>). </text:p> | ||
| </text:list-item> | ||
| <text:list-item> | ||
| <text:p text:style-name="P1298">Actually use fixed ordering when constructing matrices in the AMG hierarchy to get reproducilble results in parallel runs (<text:a xlink:type="simple" xlink:href="https://github.com/OPM/opm-simulators/pull/5646" text:style-name="Internet_20_link" text:visited-style-name="Visited_20_Internet_20_Link">#5646</text:a>). </text:p> |
There was a problem hiding this comment.
Suggested change
| <text:p text:style-name="P1298">Actually use fixed ordering when constructing matrices in the AMG hierarchy to get reproducilble results in parallel runs (<text:a xlink:type="simple" xlink:href="https://github.com/OPM/opm-simulators/pull/5646" text:style-name="Internet_20_link" text:visited-style-name="Visited_20_Internet_20_Link">#5646</text:a>). </text:p> | |
| <text:p text:style-name="P1298">Actually use fixed ordering when constructing matrices in the AMG hierarchy to get reproducible results in parallel runs (<text:a xlink:type="simple" xlink:href="https://github.com/OPM/opm-simulators/pull/5646" text:style-name="Internet_20_link" text:visited-style-name="Visited_20_Internet_20_Link">#5646</text:a>). </text:p> |
|
@blattms Thank you for the review. I have made some updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #422