Remove class XMLHelpers from the Python scripts #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakonhagland
force-pushed
the
refact_xml_helpers
branch
from
7a1e859 to
65e0d49
Compare
Remove class XMLHelpers and instead use module functions. This avoids using static class functions and is more Pythonic.
hakonhagland
force-pushed
the
refact_xml_helpers
branch
from
65e0d49 to
7a5e351
Compare
|
Tested and looks good, merging |
lisajulia
added a commit
to lisajulia/opm-reference-manual
that referenced
this pull request
Jan 10, 2025
blattms
added a commit
that referenced
this pull request
Jan 10, 2025
Fix wrongly adjusted imports from #453
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove class
XMLHelpersand instead use the modulexml_helpers. This avoids using static class functions and is a more Pythonic way of writing the same code.