Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/py action insert kw welpi wpimult alternative #5892

Merged

Conversation

lisajulia
Copy link
Contributor

Alternative to #5467 as suggested by @bska in OPM/opm-common#4136 (comment).

For the reference manual: With this PR and OPM/opm-common#4434, the keywords WELPI and WPIMULT can be used in the "insert keywords"-function in Pyaction.

@lisajulia lisajulia force-pushed the feature/pyAction-insert-kw-WELPI-WPIMULT-alternative branch 2 times, most recently from 3faf52a to b904b0d Compare January 17, 2025 11:43
Copy link
Member

@bska bska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me save for a slightly misleading comment concerning the WPIMULT keyword.

@lisajulia lisajulia force-pushed the feature/pyAction-insert-kw-WELPI-WPIMULT-alternative branch from b904b0d to 885b714 Compare January 20, 2025 11:46
Copy link
Member

@bska bska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the updates. This looks good to me now and I'll merge into master.

@bska bska merged commit 2f75635 into OPM:master Jan 20, 2025
@lisajulia lisajulia deleted the feature/pyAction-insert-kw-WELPI-WPIMULT-alternative branch January 20, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants