Preconditioner: add another template parameter for the apply constants #5899
+18
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use this to have this be cl::Buffer for openclPreconditioner there is no code using the classes as a Preconditioner<..> and this cleans up ifdefs and overloads
|
jenkins build this rocm please |
bska
reviewed
Feb 25, 2025
|
Still relevant and up to date. I split this off to a separate pr on your request, but seems gpubridge is not really maintained. |
Very good.
Yes, I remember. That's why I was a bit surprised to see that it was still lingering. I guess the handling supports the claim that
in which case we can do what we want. I'll review this now. |
bska
approved these changes
Feb 26, 2025
|
jenkins build this rocm please |
|
Build check remains green. I'll merge into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use this to have this be cl::Buffer for openclPreconditioner
there is no code using Preconditioner in a base class context and this cleans up ifdefs and overloads