OutputBlackoilModule::processElement: use a table for data extraction #6008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this please |
Okay. Do you want to tag this PR as "draft" pending such testing? |
akva2
force-pushed
the
processelement_table
branch
from
82deb77 to
c6e1b9c
Compare
|
Final timing data Timings for SPE1CASE1 [5 runs]
Timings for NORNE_ATW2013 [5 runs]
Timings for DROGON_HIST [5 runs]
|
akva2
force-pushed
the
processelement_table
branch
from
c6e1b9c to
bcf9e18
Compare
|
I will do compositional once I know if and in what shape this will be merged. |
|
jenkins build this please |
akva2
force-pushed
the
processelement_table
branch
2 times, most recently
from
44542d6 to
b334c89
Compare
|
jenkins build this please |
akva2
force-pushed
the
processelement_table
branch
3 times, most recently
from
18eb7a4 to
0715f30
Compare
akva2
force-pushed
the
processelement_table
branch
from
0715f30 to
f095e39
Compare
|
jenkins build this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies the same strategy as #5994 but to the extraction of element level data, with the same merits.
This is a hotter loop, so we may pay a cost for the increased abstraction. Should be tested on some large models