Only check trivial_target for GRUP when checking in THP #6018
+11
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#6017 should fix the same issue |
|
jenkins build this failure_report please |
|
What is the meaning of trivial_group_target? Either I do not remember or I was not involved in adding it... Either way there is no comment in SingleWellState that explains it. |
|
The original PR. #3888 |
|
jenkins build this failure_report please |
|
I think this is a bug fix and should be merged. I will add some more comments to answer this.
|
atgeirr
approved these changes
Feb 25, 2025
|
Approving the code change, improved comments would still be a good thing. |
|
jenkins build this failure_report please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix not checking THP control for other controls that GRUP