Fix for relative change (used in time step controllers) #6026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and saturation.
|
jenkins build this failure_report please |
|
note: CI is in broken state. |
Okay. Is there a way to unbreak it within a reasonable timeframe? |
|
merge the missing opm-tests PR. i pointed it out but no response yet, #5937 |
|
jenkins build this failure_report please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new and improved version of #4856. It adds the choice between using just pressure or saturation, or both, when calculating the relative change used in the time step controllers.
The current master adds pressure and saturation together in such a way that the saturation effectively doesn't do anything. Here, I've chosen to use only pressure as default, and I think this will give results more or less identical to what the current master gives.
Question: Might it make more sense to return the square root of the relative change (to get something resembling an L2 norm)?