-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Zoltan's Hyperedge Size Threshold Runtime Controllable #6036
Open
bska
wants to merge
2
commits into
OPM:master
Choose a base branch
from
bska:expose-zoltan-phg-edge-size-param
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a secondary benefit, this PR will obviate the |
jenkins build this please |
48457fe
to
93ead52
Compare
jenkins build this please |
9908c4c
to
8915efc
Compare
jenkins build this please |
8915efc
to
a34d2ef
Compare
jenkins build this please |
a34d2ef
to
fd151f0
Compare
jenkins build this please |
fd151f0
to
c9911fa
Compare
jenkins build this please |
dc15154
to
a7936dc
Compare
Slight rewording and splitting long lines for the most part.
This commit introduces a new hidden runtime parameter, ZoltanPhgEdgeSizeThreshold (--zoltan-phg-edge-size-threshold, double, default value = 0.35) which maps to Zoltan's low-level control parameter PHG_EDGE_SIZE_THRESHOLD that controls which hypergraph edges to omit/discard. We add a new parameter to 'setupZoltanParameters()' and thread the command line parameter through as an argument to this function. This is to enable runtime experimentation with this aspect of the partitioning algorithm, but end-users should typically not alter the default value without good reason.
a7936dc
to
9b935ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new hidden runtime parameter,
which maps to Zoltan's low-level control parameter
that controls which hypergraph edges to omit/discard. We add a new parameter to
setupZoltanParameters()
and thread the command line parameter through as an argument to this function.This is to enable runtime experimentation with this aspect of the partitioning algorithm, but end-users should typically not alter the default value without good reason.