Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure MSUMLINS and MSUMNEWT is updated. #6039

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

atgeirr
Copy link
Member

@atgeirr atgeirr commented Feb 26, 2025

This makes the summary output correct for these cumulative quantities also at substeps, not just report steps.

This makes the summary output correct for these cumulative
quantities also at substeps, not just report steps.
@atgeirr
Copy link
Member Author

atgeirr commented Feb 26, 2025

jenkins build this please

@bska
Copy link
Member

bska commented Feb 26, 2025

jenkins build this failure_report please

Copy link
Member

@bska bska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This does indeed solve the problem. I don't have an alternative suggestion at the minute so I'm going to update the pertinent reference solutions and then merge this into the master branch.

@bska
Copy link
Member

bska commented Feb 26, 2025

jenkins build this update_data please

jenkins4opm pushed a commit to jenkins4opm/opm-tests that referenced this pull request Feb 26, 2025
Reason: PR OPM/opm-simulators#6039

opm-common     = a6e4b524da7ee6edf3d5ac07540fcb9d3fbaf4b2
opm-grid       = 8b67f04151edb2aaa07d9e5796f9ce2d28f2c4b5
opm-simulators = eea38f9309f3c92cc3060fa5603cece06a239d91

### Changed Tests ###

  * network_standard
  * msw_model_1
  * base_model_1
  * faults_model_1
  * udt_1d-01b
  * udt_1d-01
  * udt_1d-02
  * udt_1d-03
  * norne_reperf
  * spe1case2_krnum
@bska
Copy link
Member

bska commented Feb 26, 2025

jenkins build this opm-tests=1300 please

bska added a commit to OPM/opm-tests that referenced this pull request Feb 26, 2025
@bska
Copy link
Member

bska commented Feb 26, 2025

The new reference solutions have been installed on the CI system. Merging this now to bring in the fix.

@bska bska merged commit 3ab289f into OPM:master Feb 26, 2025
1 check passed
@atgeirr atgeirr deleted the add-cumulative-iterations-substep-output branch February 27, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants