Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work in progress: Primary variables on GPU #6040

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

kjetilly
Copy link
Contributor

This is a very incomplete attempt at the moment. To get the DUNE vectors with GPU decorators, those classes have in essence been copied over to the repo and then been modified to fit on a GPU. They are in a different namespace than Dune as well.

@atgeirr
Copy link
Member

atgeirr commented Feb 27, 2025

Be aware that due to Dune having a different license than OPM (GPL 2 + exception vs GPL 3) it is not at all straightforward to move code from Dune to OPM. It is best avoided. A better solution is to make the necessary additions in a dune fork instead. That also makes it much easier to get them into upstream Dune, even if that might not be something that is likely to happen it is a much better situation.

@kjetilly
Copy link
Contributor Author

So the FieldVector stuff is not meant to be merged, but I needed a proof-of-concept to see what changes were needed, also for further work porting more to the GPU. So far the changes to it hasn't been that substantial, and can probably be made as a PR to Dune. However, no never knows with the GPU compilers, and suddenly we see that it needs a rewrite to fit on a GPU, and then I would be in favour of having it in OPM I think.

All that to say: Don't merge this, and I don't intend to mess up the licensing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants